You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "stephen-bracken (via GitHub)" <gi...@apache.org> on 2026/04/27 15:59:25 UTC

[PR] Configure S3Hook transfer_config_args via service_config [airflow]

stephen-bracken opened a new pull request, #65963:
URL: https://github.com/apache/airflow/pull/65963

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   Enable configuring the S3 transfer config arguments using the service config
   ---
   Previously the `transfer_config_args` could only be configured by passing in arguments to the `S3Hook` object. This PR makes the `S3Hook` also read arguments from the s3 `service_config` in the connection's extras to override this behaviour. e.g.
   ```
   "extras": {
     "service_config": {
       "s3": {
         "transfer_config_args": {
           "use_threads": true
         }
       }
     }
   }
   ```
   
   This allows deployment managers to change the transfer config options via configuration, for example in `S3TaskHandler.io`
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   - [X] No
   
   <!--
   Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Configure S3Hook transfer_config_args via service_config [airflow]

Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #65963:
URL: https://github.com/apache/airflow/pull/65963#discussion_r3150690621


##########
providers/amazon/docs/connections/aws.rst:
##########
@@ -383,6 +383,29 @@ provide selected options in the connection's extra field.
     }
 
 
+.. _howto/connection:aws:s3-transfer-config:
+
+S3 Transfer Config
+------------------
+
+You can use the service config to set transfer config options in :class:`~airflow.providers.amazon.aws.hooks.s3.S3Hook` methods.

Review Comment:
   Should you also mention the previous approach of configuring on the Hook directly? Or is that documented elsewhere?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Configure S3Hook transfer_config_args via service_config [airflow]

Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas merged PR #65963:
URL: https://github.com/apache/airflow/pull/65963


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Configure S3Hook transfer_config_args via service_config [airflow]

Posted by "stephen-bracken (via GitHub)" <gi...@apache.org>.
stephen-bracken commented on code in PR #65963:
URL: https://github.com/apache/airflow/pull/65963#discussion_r3153143676


##########
providers/amazon/docs/connections/aws.rst:
##########
@@ -383,6 +383,29 @@ provide selected options in the connection's extra field.
     }
 
 
+.. _howto/connection:aws:s3-transfer-config:
+
+S3 Transfer Config
+------------------
+
+You can use the service config to set transfer config options in :class:`~airflow.providers.amazon.aws.hooks.s3.S3Hook` methods.

Review Comment:
   The `transfer_config_args` argument for the hook is not configurable as part of the connection, so I haven't mentioned it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org