You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/09/07 16:10:46 UTC
[jira] [Commented] (CB-9617) Add plugin or platform doesn't create
www/plugins folder
[ https://issues.apache.org/jira/browse/CB-9617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733754#comment-14733754 ]
ASF GitHub Bot commented on CB-9617:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/297
CB-9617 Fixes incorrect project state after adding/removing plugins
This fixes [CB-9617](https://issues.apache.org/jira/browse/CB-9617)
The cause of problem is that `plugman.prepare` functionality was eliminated (since the new flow assumes that plugin installation is totally handled by `PlatformApi` instance) and plugin's assets and js-files are now get copied into app's `www` folder by `PlatforfmApi.prepare`.
Due to this at the time after _plugin installation_ and before _prepare_ the platform folder might exist in inconsistant state.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9617
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #297
----
commit 5706c3475cfc66fd952b2227ea117da63f852c11
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-09-07T13:36:35Z
CB-9617 Fixes incorrect project state after adding/removing plugins
----
> Add plugin or platform doesn't create www/plugins folder
> --------------------------------------------------------
>
> Key: CB-9617
> URL: https://issues.apache.org/jira/browse/CB-9617
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: Master
> Reporter: Tim Barham
> Assignee: Vladimir Kotikov
> Labels: PlatformApi
>
> Since the new Platform API polyfill, adding a platform or a plugin doesn't create the www/plugins folder, or copy the plugin/plugins there.
> *Repo adding a platform:*
> 1. Create a new blank project
> 2. {{cordova plugin add cordova-plugin-camera}}
> 3. {{cordova platform add browser}}
> *Expected:*
> The {{platforms/browser/www}} folder contains a {{plugins}} folder that contains a {{cordova-plugin-camera}} folder.
> *Actual:*
> It doesn't.
> *Repo adding a plugin:*
> If you add the platform before the plugin, the same result occurs. Also, consider this scenario:
> 1. Create a new blank project
> 2. {{cordova platform add browser}}
> 3. {{cordova plugin add cordova-plugin-camera}}
> 4. {{cordova prepare}}
> 5. {{cordova plugin add cordova-plugin-device}}
> *Expected:*
> The platforms\browser\www\plugins folder should contain folders for {{cordova-plugin-camera}} and {{cordova-plugin-device}}.
> *Actual:*
> It only contains a folder for {{cordova-plugin-camera}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org