[GitHub] [hbase] bharathv commented on a change in pull request #880: HBASE-18382 add transport type info into Thrift UI

[GitBox <gi...@apache.org>]

bharathv commented on a change in pull request #880: HBASE-18382 add transport type info into Thrift UI
URL: https://github.com/apache/hbase/pull/880#discussion_r353311571
 
 

 ##########
 File path: hbase-thrift/src/main/resources/hbase-webapps/thrift/thrift.jsp
 ##########
 @@ -31,9 +31,11 @@ String serverType = (String)getServletContext().getAttribute("hbase.thrift.serve
 long startcode = conf.getLong("startcode", System.currentTimeMillis());
 String listenPort = conf.get("hbase.regionserver.thrift.port", "9090");
 ImplType implType = ImplType.getServerImpl(conf);
-String framed = implType.isAlwaysFramed()
-    ? "true" : conf.get("hbase.regionserver.thrift.framed", "false");
-String compact = conf.get("hbase.regionserver.thrift.compact", "false");
+
+String transport = implType.isAlwaysFramed() ||conf.getBoolean("hbase.regionserver.thrift.framed", false) ? "Framed" : "Standard";
 
 Review comment:
   Couple of nits:
   
   - Ternary operator's boolean expression should be parenthesized, as per the Java style guide that HBase follows. Also a space after '||'. https://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html
   -  Can you please take care of max line width (100 chars). Looks like checkstyle does not run in jsp files. GOod to fix it before committing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services