You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Rajini Sivaram <ra...@googlemail.com> on 2015/04/13 21:15:03 UTC
Re: Review Request 33125: Add comment to timing fix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33125/
-----------------------------------------------------------
(Updated April 13, 2015, 7:15 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Add comment to timing fix
Bugs: KAFKA-2089
https://issues.apache.org/jira/browse/KAFKA-2089
Repository: kafka
Description
-------
Patch for KAFKA-2089: Fix timing issue in MetadataTest
Diffs (updated)
-----
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java 928087d29deb80655ca83726c1ebc45d76468c1f
Diff: https://reviews.apache.org/r/33125/diff/
Testing
-------
Thanks,
Rajini Sivaram
Re: Review Request 33125: Add comment to timing fix
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33125/#review93368
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On April 13, 2015, 7:15 p.m., Rajini Sivaram wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33125/
> -----------------------------------------------------------
>
> (Updated April 13, 2015, 7:15 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2089
> https://issues.apache.org/jira/browse/KAFKA-2089
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Patch for KAFKA-2089: Fix timing issue in MetadataTest
>
>
> Diffs
> -----
>
> clients/src/test/java/org/apache/kafka/clients/MetadataTest.java 928087d29deb80655ca83726c1ebc45d76468c1f
>
> Diff: https://reviews.apache.org/r/33125/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajini Sivaram
>
>
Re: Review Request 33125: Add comment to timing fix
Posted by Edward Ribeiro <ed...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33125/#review93953
-----------------------------------------------------------
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java (line 58)
<https://reviews.apache.org/r/33125/#comment148391>
Wow, 1 millisecond?! Does it make a difference? Just curious. :)
- Edward Ribeiro
On April 13, 2015, 7:15 p.m., Rajini Sivaram wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33125/
> -----------------------------------------------------------
>
> (Updated April 13, 2015, 7:15 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2089
> https://issues.apache.org/jira/browse/KAFKA-2089
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Patch for KAFKA-2089: Fix timing issue in MetadataTest
>
>
> Diffs
> -----
>
> clients/src/test/java/org/apache/kafka/clients/MetadataTest.java 928087d29deb80655ca83726c1ebc45d76468c1f
>
> Diff: https://reviews.apache.org/r/33125/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajini Sivaram
>
>
Re: Review Request 33125: Add comment to timing fix
Posted by Rajini Sivaram <ra...@googlemail.com>.
> On April 25, 2015, 5:11 a.m., Guozhang Wang wrote:
> > clients/src/test/java/org/apache/kafka/clients/MetadataTest.java, line 58
> > <https://reviews.apache.org/r/33125/diff/2/?file=926187#file926187line58>
> >
> > Do we need this sleep?
Guozhang, Sorry, had missed this note. The sleep avoids a tight loop in the main test thread while it is waiting for the other two threads to complete.
- Rajini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33125/#review81581
-----------------------------------------------------------
On April 13, 2015, 7:15 p.m., Rajini Sivaram wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33125/
> -----------------------------------------------------------
>
> (Updated April 13, 2015, 7:15 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2089
> https://issues.apache.org/jira/browse/KAFKA-2089
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Patch for KAFKA-2089: Fix timing issue in MetadataTest
>
>
> Diffs
> -----
>
> clients/src/test/java/org/apache/kafka/clients/MetadataTest.java 928087d29deb80655ca83726c1ebc45d76468c1f
>
> Diff: https://reviews.apache.org/r/33125/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajini Sivaram
>
>
Re: Review Request 33125: Add comment to timing fix
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33125/#review81581
-----------------------------------------------------------
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java
<https://reviews.apache.org/r/33125/#comment132016>
Do we need this sleep?
- Guozhang Wang
On April 13, 2015, 7:15 p.m., Rajini Sivaram wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33125/
> -----------------------------------------------------------
>
> (Updated April 13, 2015, 7:15 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2089
> https://issues.apache.org/jira/browse/KAFKA-2089
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Patch for KAFKA-2089: Fix timing issue in MetadataTest
>
>
> Diffs
> -----
>
> clients/src/test/java/org/apache/kafka/clients/MetadataTest.java 928087d29deb80655ca83726c1ebc45d76468c1f
>
> Diff: https://reviews.apache.org/r/33125/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajini Sivaram
>
>