You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by eiri <gi...@git.apache.org> on 2016/03/22 19:33:40 UTC

[GitHub] couchdb-chttpd pull request: Fix CORS max_age configuration parame...

GitHub user eiri opened a pull request:

    https://github.com/apache/couchdb-chttpd/pull/110

    Fix CORS max_age configuration parameter

    Header `"Access-Control-Max-Age"` used by a browser to define for how long to keep preflight request's response cached.
    
    This fix makes this parameter configurable through config section `[cors]`, attribute `max_age`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-chttpd fix-cors-max_age

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-chttpd/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #110
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd pull request #110: Fix CORS max_age configuration parameter

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-chttpd/pull/110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd issue #110: Fix CORS max_age configuration parameter

Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on the issue:

    https://github.com/apache/couchdb-chttpd/pull/110
  
    +1. All tests pass locally.
    ```
    ==> chttpd (eunit)
    Compiled test/chttpd_cors_test.erl
        Running test function(s):
          chttpd_cors_test:cors_enabled_simple_config_test_/0
          chttpd_cors_test:cors_enabled_custom_config_test_/0
    ======================== EUnit ========================
    Simple CORS config with custom allow_methods/allow_headers/exposed_headers
      chttpd_cors_test:356: test_good_headers_preflight_request_with_custom_config_...ok
      chttpd_cors_test:358: test_good_headers_preflight_request_with_custom_config_...ok
      chttpd_cors_test:360: test_good_headers_preflight_request_with_custom_config_...ok
      chttpd_cors_test:362: test_good_headers_preflight_request_with_custom_config_...ok
      chttpd_cors_test:446: test_db_request_with_custom_config_...ok
      chttpd_cors_test:448: test_db_request_with_custom_config_...ok
      [done in 0.032 s]
    Simple CORS config
      chttpd_cors_test:133: assert_not_preflight_...ok
      chttpd_cors_test:375: test_preflight_request_...ok
      chttpd_cors_test:377: test_preflight_request_...ok
      chttpd_cors_test:318: test_bad_headers_preflight_request_...ok
      chttpd_cors_test:133: assert_not_preflight_...ok
      chttpd_cors_test:333: test_good_headers_preflight_request_...ok
      chttpd_cors_test:335: test_good_headers_preflight_request_...ok
      chttpd_cors_test:337: test_good_headers_preflight_request_...ok
      chttpd_cors_test:432: test_db_request_...ok
      chttpd_cors_test:434: test_db_request_...ok
      chttpd_cors_test:461: test_db_preflight_request_...ok
      chttpd_cors_test:463: test_db_preflight_request_...ok
      chttpd_cors_test:477: test_db_host_origin_request_...ok
      chttpd_cors_test:479: test_db_host_origin_request_...ok
      chttpd_cors_test:491: test_preflight_origin_helper_...ok
      chttpd_cors_test:491: test_preflight_origin_helper_...ok
      chttpd_cors_test:491: test_preflight_origin_helper_...ok
      chttpd_cors_test:531: test_case_sensitive_mismatch_of_allowed_origins_...ok
      chttpd_cors_test:533: test_case_sensitive_mismatch_of_allowed_origins_...ok
      [done in 0.057 s]
    =======================================================
      All 25 tests passed.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---