You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/02/05 23:59:41 UTC
[GitHub] zeppelin pull request #1975: [ZEPPELIN-2046] The final output is a little in...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1975
[ZEPPELIN-2046] The final output is a little inconsistent with the streaming output
### What is this PR for?
he final output is not consistent with the streaming output. The final output has one extra blank lines between outputs.
### What type of PR is it?
Bug Fix
### Todos
* [x] - make streaming output and static output the same
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2046
### How should this be tested?
run
```
%sh echo hello && echo "" && sleep 1 && echo world && sleep 1
```
and see if streaming output is the same to final output
### Screenshots (if appropriate)
before
after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin output_append_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1975.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1975
----
commit e883fdf6bc0000d5ba44c2d116c3eb3ca745eab5
Author: Lee moon soo <mo...@apache.org>
Date: 2017-02-05T23:54:03Z
Make streaming output and static output the same
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1975
@zjffdu Created an issue to address unnecessary newline from SparkInterpreter https://issues.apache.org/jira/browse/ZEPPELIN-2067
Merge this PR to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1975
@Leemoonsoo I don't think the blank line is caused by scala. Here's what I see in zeppelin 0.6.2 and zeppelin 0.7, both use spark 1.6.2
Zeppelin 0.7
Zeppelin 0.6.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1975
@Leemoonsoo I still on extra blank between outputs which is inconsistent with zeppelin 0.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1975
@zjffdu If blank lines of output is output from "import ..." in Scala, that's slightly different issue.
Otherwise, please give me an example
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1975
@zjffdu If you take a look https://github.com/apache/zeppelin/blob/master/notebook/2A94M5J1Z/note.json#L89, you'll see there're two new lines between outputs. Spark interpreter (scala) seems printing one more new line between outputs.
Current master displays those new lines correctly. 0.6.x didn't displayed those new line well.
So, i think one more new line between output in scala is problem need be addressed in SparkInterpreter in separate issue, while this PR addresses difference between streaming output and static output.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1975
I think we can use only 1 `div` element instead of appending `div` for streaming output by replacing it's contents (`html()`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1975
Thanks @Leemoonsoo , it make sense to fix it in another PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1975: [ZEPPELIN-2046] The final output is a little in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1975
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---