You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Esteve Fernandez (JIRA)" <ji...@apache.org> on 2009/09/14 17:36:58 UTC
[jira] Created: (THRIFT-581) Add a testsuite for txThrift (Twisted)
Add a testsuite for txThrift (Twisted)
--------------------------------------
Key: THRIFT-581
URL: https://issues.apache.org/jira/browse/THRIFT-581
Project: Thrift
Issue Type: Test
Components: Test Suite
Reporter: Esteve Fernandez
Priority: Critical
Thrift lacks a testsuite for Twisted, this is unacceptable and should be addressed as soon as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-581) Add a testsuite for txThrift
(Twisted)
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez reassigned THRIFT-581:
---------------------------------------
Assignee: Esteve Fernandez
> Add a testsuite for txThrift (Twisted)
> --------------------------------------
>
> Key: THRIFT-581
> URL: https://issues.apache.org/jira/browse/THRIFT-581
> Project: Thrift
> Issue Type: Test
> Components: Test Suite
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Priority: Critical
> Attachments: 581-twisted-testsuite.patch
>
>
> Thrift lacks a testsuite for Twisted, this is unacceptable and should be addressed as soon as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-581) Add a testsuite for txThrift (Twisted)
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier closed THRIFT-581.
------------------------------
Resolution: Fixed
Fix Version/s: 0.6
just committed this and ran it's unit test => passed!
> Add a testsuite for txThrift (Twisted)
> --------------------------------------
>
> Key: THRIFT-581
> URL: https://issues.apache.org/jira/browse/THRIFT-581
> Project: Thrift
> Issue Type: Test
> Components: Test Suite
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Priority: Critical
> Fix For: 0.6
>
> Attachments: 581-twisted-testsuite.patch, THRIFT-581_twisted-testsuite.v2.patch
>
>
> Thrift lacks a testsuite for Twisted, this is unacceptable and should be addressed as soon as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-581) Add a testsuite for txThrift (Twisted)
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-581:
-------------------------------
Attachment: THRIFT-581_twisted-testsuite.v2.patch
Hi Esteve, tests are important and that's why I had a look on this patch.
I modified it a bit:
* added namespace py.twisted to ThriftTest.thrift
* ASF License to test_suite.py
* recreate patch
now [^THRIFT-581_twisted-testsuite.v2.patch] applies to revision 1005758 and from my perspective => ready to commit!
-roger
> Add a testsuite for txThrift (Twisted)
> --------------------------------------
>
> Key: THRIFT-581
> URL: https://issues.apache.org/jira/browse/THRIFT-581
> Project: Thrift
> Issue Type: Test
> Components: Test Suite
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Priority: Critical
> Attachments: 581-twisted-testsuite.patch, THRIFT-581_twisted-testsuite.v2.patch
>
>
> Thrift lacks a testsuite for Twisted, this is unacceptable and should be addressed as soon as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-581) Add a testsuite for txThrift (Twisted)
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-581:
------------------------------------
Attachment: 581-twisted-testsuite.patch
This patch adds a testsuite for the Twisted generator. It's fairly simple, but it mimics the blocking version. I'm anything but an autotools expert, so I'd be really happy if someone could review the changes :-)
> Add a testsuite for txThrift (Twisted)
> --------------------------------------
>
> Key: THRIFT-581
> URL: https://issues.apache.org/jira/browse/THRIFT-581
> Project: Thrift
> Issue Type: Test
> Components: Test Suite
> Reporter: Esteve Fernandez
> Priority: Critical
> Attachments: 581-twisted-testsuite.patch
>
>
> Thrift lacks a testsuite for Twisted, this is unacceptable and should be addressed as soon as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-581) Add a testsuite for txThrift
(Twisted)
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919328#action_12919328 ]
Esteve Fernandez commented on THRIFT-581:
-----------------------------------------
Hi Roger
> Hi Esteve, tests are important and that's why I had a look on this patch.
Cool! Thanks a lot for taking over this :-)
> now THRIFT-581_twisted-testsuite.v2.patch applies to revision 1005758 and from my perspective => ready to
> commit!
+1 Looks fine to me
Thanks!
> Add a testsuite for txThrift (Twisted)
> --------------------------------------
>
> Key: THRIFT-581
> URL: https://issues.apache.org/jira/browse/THRIFT-581
> Project: Thrift
> Issue Type: Test
> Components: Test Suite
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Priority: Critical
> Attachments: 581-twisted-testsuite.patch, THRIFT-581_twisted-testsuite.v2.patch
>
>
> Thrift lacks a testsuite for Twisted, this is unacceptable and should be addressed as soon as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-581) Add a testsuite for txThrift
(Twisted)
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919319#action_12919319 ]
Bryan Duxbury commented on THRIFT-581:
--------------------------------------
Roger - if you think it's good to go, I'd say your work to rebase it to HEAD counts as a suitable review, so just commit it.
> Add a testsuite for txThrift (Twisted)
> --------------------------------------
>
> Key: THRIFT-581
> URL: https://issues.apache.org/jira/browse/THRIFT-581
> Project: Thrift
> Issue Type: Test
> Components: Test Suite
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Priority: Critical
> Attachments: 581-twisted-testsuite.patch, THRIFT-581_twisted-testsuite.v2.patch
>
>
> Thrift lacks a testsuite for Twisted, this is unacceptable and should be addressed as soon as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.