You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by se...@apache.org on 2020/03/05 14:52:26 UTC
[flink] 01/06: [FLINK-16177][refactor][checkpointing] Remove
unnecessary test constructor from PendingCheckpoint.
This is an automated email from the ASF dual-hosted git repository.
sewen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit ef8402ee0c119a1dafe42157d3cbfef4c84dff4c
Author: Stephan Ewen <se...@apache.org>
AuthorDate: Thu Feb 27 16:44:24 2020 +0100
[FLINK-16177][refactor][checkpointing] Remove unnecessary test constructor from PendingCheckpoint.
The constructor is adding trivial benefit and is only used once.
---
.../runtime/checkpoint/PendingCheckpoint.java | 23 +---------------------
.../runtime/checkpoint/PendingCheckpointTest.java | 3 ++-
2 files changed, 3 insertions(+), 23 deletions(-)
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
index a596acb..ae9027d 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
@@ -117,30 +117,9 @@ public class PendingCheckpoint {
private volatile ScheduledFuture<?> cancellerHandle;
- private CheckpointException failureCause = null;
+ private CheckpointException failureCause;
// --------------------------------------------------------------------------------------------
- public PendingCheckpoint(
- JobID jobId,
- long checkpointId,
- long checkpointTimestamp,
- Map<ExecutionAttemptID, ExecutionVertex> verticesToConfirm,
- Collection<String> masterStateIdentifiers,
- CheckpointProperties props,
- CheckpointStorageLocation targetLocation,
- Executor executor) {
-
- this(
- jobId,
- checkpointId,
- checkpointTimestamp,
- verticesToConfirm,
- masterStateIdentifiers,
- props,
- targetLocation,
- executor,
- new CompletableFuture<>());
- }
public PendingCheckpoint(
JobID jobId,
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/PendingCheckpointTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/PendingCheckpointTest.java
index cdda728..c78c077 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/PendingCheckpointTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/PendingCheckpointTest.java
@@ -462,7 +462,8 @@ public class PendingCheckpointTest {
masterStateIdentifiers,
props,
location,
- executor);
+ executor,
+ new CompletableFuture<>());
}
@SuppressWarnings("unchecked")