You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/11/03 02:39:59 UTC
[jira] Created: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
SyncRequestProcessor snapping too frequently - counts non-log events as log events
----------------------------------------------------------------------------------
Key: ZOOKEEPER-568
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
Project: Zookeeper
Issue Type: Bug
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Fix For: 3.3.0
Noticed the following issues in SyncRequestProcessor
1) logCount is incremented even for non-log events (say getData)
txnlog should return indication if request was logged or not (if hdr ==null it returns)
also:
2) move r.nextInt below logCount++ (ie if an actual log event)
3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774725#action_12774725 ]
Hudson commented on ZOOKEEPER-568:
----------------------------------
Integrated in ZooKeeper-trunk #522 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/522/])
> SyncRequestProcessor snapping too frequently - counts non-log events as log events
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-568
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-568.patch
>
>
> Noticed the following issues in SyncRequestProcessor
> 1) logCount is incremented even for non-log events (say getData)
> txnlog should return indication if request was logged or not (if hdr ==null it returns)
> also:
> 2) move r.nextInt below logCount++ (ie if an actual log event)
> 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-568:
--------------------------------------
Assignee: Patrick Hunt
> SyncRequestProcessor snapping too frequently - counts non-log events as log events
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-568
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
>
> Noticed the following issues in SyncRequestProcessor
> 1) logCount is incremented even for non-log events (say getData)
> txnlog should return indication if request was logged or not (if hdr ==null it returns)
> also:
> 2) move r.nextInt below logCount++ (ie if an actual log event)
> 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-568:
------------------------------------
Hadoop Flags: [Reviewed]
> SyncRequestProcessor snapping too frequently - counts non-log events as log events
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-568
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-568.patch
>
>
> Noticed the following issues in SyncRequestProcessor
> 1) logCount is incremented even for non-log events (say getData)
> txnlog should return indication if request was logged or not (if hdr ==null it returns)
> also:
> 2) move r.nextInt below logCount++ (ie if an actual log event)
> 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772822#action_12772822 ]
Patrick Hunt commented on ZOOKEEPER-568:
----------------------------------------
move traceMask into isTraceEnabled check
> SyncRequestProcessor snapping too frequently - counts non-log events as log events
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-568
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Fix For: 3.3.0
>
>
> Noticed the following issues in SyncRequestProcessor
> 1) logCount is incremented even for non-log events (say getData)
> txnlog should return indication if request was logged or not (if hdr ==null it returns)
> also:
> 2) move r.nextInt below logCount++ (ie if an actual log event)
> 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-568:
-----------------------------------
Attachment: ZOOKEEPER-568.patch
this patch addressed the desc/comments. No tests as it's really an optimization.
> SyncRequestProcessor snapping too frequently - counts non-log events as log events
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-568
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-568.patch
>
>
> Noticed the following issues in SyncRequestProcessor
> 1) logCount is incremented even for non-log events (say getData)
> txnlog should return indication if request was logged or not (if hdr ==null it returns)
> also:
> 2) move r.nextInt below logCount++ (ie if an actual log event)
> 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-568:
-----------------------------------
Status: Patch Available (was: Open)
> SyncRequestProcessor snapping too frequently - counts non-log events as log events
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-568
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-568.patch
>
>
> Noticed the following issues in SyncRequestProcessor
> 1) logCount is incremented even for non-log events (say getData)
> txnlog should return indication if request was logged or not (if hdr ==null it returns)
> also:
> 2) move r.nextInt below logCount++ (ie if an actual log event)
> 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774437#action_12774437 ]
Benjamin Reed commented on ZOOKEEPER-568:
-----------------------------------------
+1 great job pat!
> SyncRequestProcessor snapping too frequently - counts non-log events as log events
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-568
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-568.patch
>
>
> Noticed the following issues in SyncRequestProcessor
> 1) logCount is incremented even for non-log events (say getData)
> txnlog should return indication if request was logged or not (if hdr ==null it returns)
> also:
> 2) move r.nextInt below logCount++ (ie if an actual log event)
> 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774394#action_12774394 ]
Hadoop QA commented on ZOOKEEPER-568:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12424223/ZOOKEEPER-568.patch
against trunk revision 831486.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/49/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/49/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/49/console
This message is automatically generated.
> SyncRequestProcessor snapping too frequently - counts non-log events as log events
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-568
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-568.patch
>
>
> Noticed the following issues in SyncRequestProcessor
> 1) logCount is incremented even for non-log events (say getData)
> txnlog should return indication if request was logged or not (if hdr ==null it returns)
> also:
> 2) move r.nextInt below logCount++ (ie if an actual log event)
> 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-568:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed revision 833639.
> SyncRequestProcessor snapping too frequently - counts non-log events as log events
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-568
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-568.patch
>
>
> Noticed the following issues in SyncRequestProcessor
> 1) logCount is incremented even for non-log events (say getData)
> txnlog should return indication if request was logged or not (if hdr ==null it returns)
> also:
> 2) move r.nextInt below logCount++ (ie if an actual log event)
> 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-568) SyncRequestProcessor snapping too
frequently - counts non-log events as log events
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773280#action_12773280 ]
Benjamin Reed commented on ZOOKEEPER-568:
-----------------------------------------
i think that r.nextInt is in the right place. we should document why it is there. (so that all the replicas aren't snap shotting at the same time.)
apart from not counting the read only requests, we should also process them immediately if there are no pending writes.
> SyncRequestProcessor snapping too frequently - counts non-log events as log events
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-568
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Fix For: 3.3.0
>
>
> Noticed the following issues in SyncRequestProcessor
> 1) logCount is incremented even for non-log events (say getData)
> txnlog should return indication if request was logged or not (if hdr ==null it returns)
> also:
> 2) move r.nextInt below logCount++ (ie if an actual log event)
> 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.