You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org> on 2026/03/09 16:43:58 UTC
[PR] RATIS-2429. ratis-bom module fails to deploy due to missing distributionManagement configuration [ratis]
OneSizeFitsQuorum opened a new pull request, #1371:
URL: https://github.com/apache/ratis/pull/1371
see https://issues.apache.org/jira/browse/RATIS-2429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2429. ratis-bom module fails to deploy due to missing distributionManagement configuration [ratis]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #1371:
URL: https://github.com/apache/ratis/pull/1371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2429. ratis-bom module fails to deploy due to missing distributionManagement configuration [ratis]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #1371:
URL: https://github.com/apache/ratis/pull/1371#discussion_r2911541672
##########
ratis-bom/pom.xml:
##########
@@ -22,8 +22,21 @@
<packaging>pom</packaging>
+ <distributionManagement>
+ <repository>
+ <id>apache.staging.https</id>
+ <name>Apache Release Distribution Repository</name>
+ <url>https://repository.apache.org/service/local/staging/deploy/maven2</url>
+ </repository>
+ <snapshotRepository>
+ <id>apache.snapshots.https</id>
+ <name>Apache Development Snapshot Repository</name>
+ <url>https://repository.apache.org/content/repositories/snapshots</url>
+ </snapshotRepository>
+ </distributionManagement>
Review Comment:
Make Sense! Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2429. ratis-bom module fails to deploy due to missing distributionManagement configuration [ratis]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #1371:
URL: https://github.com/apache/ratis/pull/1371#discussion_r2909603360
##########
ratis-bom/pom.xml:
##########
@@ -22,8 +22,21 @@
<packaging>pom</packaging>
+ <distributionManagement>
+ <repository>
+ <id>apache.staging.https</id>
+ <name>Apache Release Distribution Repository</name>
+ <url>https://repository.apache.org/service/local/staging/deploy/maven2</url>
+ </repository>
+ <snapshotRepository>
+ <id>apache.snapshots.https</id>
+ <name>Apache Development Snapshot Repository</name>
+ <url>https://repository.apache.org/content/repositories/snapshots</url>
+ </snapshotRepository>
+ </distributionManagement>
Review Comment:
My concern is that if someone builds the project with custom repo (`-DdistMgmtStagingUrl=...` or similar), `ratis-bom` might unexpectedly get deployed to Apache. Copying the properties would prevent it, custom value would be applied to `ratis-bom` lke all other modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2429. ratis-bom module fails to deploy due to missing distributionManagement configuration [ratis]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #1371:
URL: https://github.com/apache/ratis/pull/1371#discussion_r2906854384
##########
ratis-bom/pom.xml:
##########
@@ -22,8 +22,21 @@
<packaging>pom</packaging>
+ <distributionManagement>
+ <repository>
+ <id>apache.staging.https</id>
+ <name>Apache Release Distribution Repository</name>
+ <url>https://repository.apache.org/service/local/staging/deploy/maven2</url>
+ </repository>
+ <snapshotRepository>
+ <id>apache.snapshots.https</id>
+ <name>Apache Development Snapshot Repository</name>
+ <url>https://repository.apache.org/content/repositories/snapshots</url>
+ </snapshotRepository>
+ </distributionManagement>
+
<properties>
- <ratis.thirdparty.version>1.0.10</ratis.thirdparty.version>
+ <ratis.thirdparty.version>1.0.11</ratis.thirdparty.version>
Review Comment:
Nice catch, I missed following my own comment:
https://github.com/apache/ratis/blob/1433b4cbf7350afcf9b2f871dd48c48e17a91a1d/pom.xml#L185-L186
##########
ratis-bom/pom.xml:
##########
@@ -22,8 +22,21 @@
<packaging>pom</packaging>
+ <distributionManagement>
+ <repository>
+ <id>apache.staging.https</id>
+ <name>Apache Release Distribution Repository</name>
+ <url>https://repository.apache.org/service/local/staging/deploy/maven2</url>
+ </repository>
+ <snapshotRepository>
+ <id>apache.snapshots.https</id>
+ <name>Apache Development Snapshot Repository</name>
+ <url>https://repository.apache.org/content/repositories/snapshots</url>
+ </snapshotRepository>
+ </distributionManagement>
Review Comment:
Should we copy from root POM both `distributionManagement` and the properties it refers to, as is?
https://github.com/apache/ratis/blob/1433b4cbf7350afcf9b2f871dd48c48e17a91a1d/pom.xml#L36-L47
https://github.com/apache/ratis/blob/1433b4cbf7350afcf9b2f871dd48c48e17a91a1d/pom.xml#L171-L176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2429. ratis-bom module fails to deploy due to missing distributionManagement configuration [ratis]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #1371:
URL: https://github.com/apache/ratis/pull/1371#discussion_r2909446266
##########
ratis-bom/pom.xml:
##########
@@ -22,8 +22,21 @@
<packaging>pom</packaging>
+ <distributionManagement>
+ <repository>
+ <id>apache.staging.https</id>
+ <name>Apache Release Distribution Repository</name>
+ <url>https://repository.apache.org/service/local/staging/deploy/maven2</url>
+ </repository>
+ <snapshotRepository>
+ <id>apache.snapshots.https</id>
+ <name>Apache Development Snapshot Repository</name>
+ <url>https://repository.apache.org/content/repositories/snapshots</url>
+ </snapshotRepository>
+ </distributionManagement>
Review Comment:
Currently, there are no properties in the ratis-bom, so I think the current style is consistent. I think it's both OK whether to change it or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2429. ratis-bom module fails to deploy due to missing distributionManagement configuration [ratis]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #1371:
URL: https://github.com/apache/ratis/pull/1371#discussion_r2909448517
##########
ratis-bom/pom.xml:
##########
@@ -22,8 +22,21 @@
<packaging>pom</packaging>
+ <distributionManagement>
+ <repository>
+ <id>apache.staging.https</id>
+ <name>Apache Release Distribution Repository</name>
+ <url>https://repository.apache.org/service/local/staging/deploy/maven2</url>
+ </repository>
+ <snapshotRepository>
+ <id>apache.snapshots.https</id>
+ <name>Apache Development Snapshot Repository</name>
+ <url>https://repository.apache.org/content/repositories/snapshots</url>
+ </snapshotRepository>
+ </distributionManagement>
+
<properties>
- <ratis.thirdparty.version>1.0.10</ratis.thirdparty.version>
+ <ratis.thirdparty.version>1.0.11</ratis.thirdparty.version>
Review Comment:
It was just an accidental discovery :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org