You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/10/27 13:38:27 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1211: refactor(macro): use CHECK to replace dassert_f/dassert (part2)
acelyc111 opened a new pull request, #1211:
URL: https://github.com/apache/incubator-pegasus/pull/1211
https://github.com/apache/incubator-pegasus/issues/1204
- use `CHECK` to replace more part of `dassert_f`, which are used to check a single condition
- use `CHECK` to replace more part of `dassert`, which are used to check a single condition. And update to use `fmt` style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1211: refactor(macro): use CHECK to replace dassert_f/dassert (part2)
Posted by GitBox <gi...@apache.org>.
empiredan commented on code in PR #1211:
URL: https://github.com/apache/incubator-pegasus/pull/1211#discussion_r1007682089
##########
src/nfs/nfs_client_impl.cpp:
##########
@@ -449,9 +450,7 @@ void nfs_client_impl::continue_write()
std::string file_path =
dsn::utils::filesystem::path_combine(fc->user_req->file_size_req.dst_dir, fc->file_name);
std::string path = dsn::utils::filesystem::remove_file_name(file_path.c_str());
- if (!dsn::utils::filesystem::create_directory(path)) {
- dassert(false, "create directory %s failed", path.c_str());
- }
+ CHECK(dsn::utils::filesystem::create_directory(path), "create directory {} failed");
Review Comment:
```suggestion
CHECK(dsn::utils::filesystem::create_directory(path), "create directory {} failed", path);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1211: refactor(macro): use CHECK to replace dassert_f/dassert (part2)
Posted by GitBox <gi...@apache.org>.
empiredan merged PR #1211:
URL: https://github.com/apache/incubator-pegasus/pull/1211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org