You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hugo Trippaers <hu...@apache.org> on 2014/06/24 10:27:56 UTC
create_schema.sql
Dear committers,
When either committing or reviewing, please pay attention to the fact the create_schema.sql should NOT be modified under any circumstances. Since release 4.1 this file is considered frozen and updates to the schema will be in the upgrade scripts for the versions.
At the moment a number of commits have been accepted that modify the schema which we now have to clean up or revert.
Please pay attention to this.
Cheers,
Hugo
Re: create_schema.sql
Posted by Ian Duffy <ia...@ianduffy.ie>.
Apologizes for my commit to it yesterday.
Was removing erroneous lines brought in by the other commit.
On 24 June 2014 10:27, Rajani Karuturi <Ra...@citrix.com> wrote:
> how about calculating the md5 checksum of the file and a build failure
> incase the checksum changes?
>
> liquibase(http://www.liquibase.org/) manages its changesets using md5
> hash.
>
>
> ~Rajani
>
>
>
> On 24-Jun-2014, at 2:48 pm, Daan Hoogland <daan.hoogland@gmail.com<mailto:
> daan.hoogland@gmail.com>> wrote:
>
> including the source release? I don't like:( I do agree that some kind
> of guard would help, though
>
> On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam <tsp@apache.org
> <ma...@apache.org>> wrote:
> On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
> It should be included in any release
>
> so packaging can bring it back i thought. just a thought.
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com<http://BigRock.com>
>
>
>
>
> --
> Daan
>
>
Re: create_schema.sql
Posted by Rajani Karuturi <Ra...@citrix.com>.
how about calculating the md5 checksum of the file and a build failure incase the checksum changes?
liquibase(http://www.liquibase.org/) manages its changesets using md5 hash.
~Rajani
On 24-Jun-2014, at 2:48 pm, Daan Hoogland <da...@gmail.com>> wrote:
including the source release? I don't like:( I do agree that some kind
of guard would help, though
On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam <ts...@apache.org>> wrote:
On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
It should be included in any release
so packaging can bring it back i thought. just a thought.
--
Prasanna.,
------------------------
Powered by BigRock.com<http://BigRock.com>
--
Daan
Re: create_schema.sql
Posted by David Nalley <da...@gnsa.us>.
On Sat, Jun 28, 2014 at 1:26 AM, Rohit Yadav <ro...@gmail.com> wrote:
> On Sat, Jun 28, 2014 at 2:43 AM, David Nalley <da...@gnsa.us> wrote:
>
>> we could always add it to .gitignore
>> That wouldn't stop changes from being made, but it would stop changes
>> from propagating to the repo itself.
>>
>
> But David, one can git add -f or something. Can we put a git hook (post
> commit/push) on the ASF repo if possible which could send us an alert email
> when certain files are changed?
>
True they can do add -f; though hopefully no committer would do such
things; and submitted patches would be caught.
Also, on further review .gitignore is a poor mechanism when used in
conjunction with git commit -a
As for a git hook. No, not a real git hook, but look at gitpubsub for options.
http://www.apache.org/dev/gitpubsub.html
> Daan, we could have a cron job that checks this for us and alert us on
> email if certain files are changed? Here something like Herald could work
> which triggers alerts when code changes pass a complex condition (changing
> of file, or code etc.) [1]
>
> [1] http://phabricator.org/applications/herald/
>
> Regards.
>
>
>>
>> On Fri, Jun 27, 2014 at 5:05 PM, Daan Hoogland <da...@gmail.com>
>> wrote:
>> > Rohit, sorry for the late reaction. this works for defending yourself
>> > and maybe we should all do it, it doesn't defend the repo from
>> > checkins. I would prefer that.
>> >
>> > On Tue, Jun 24, 2014 at 10:07 PM, Rohit Yadav <ro...@gmail.com>
>> wrote:
>> >> Hi Daan and others,
>> >>
>> >> Let me share a way to guard files that interest us by alerting us using
>> the
>> >> following shell script git hook:
>> >>
>> >> Put the following your .git/hooks/post-merge (make sure to chmod +x the
>> >> following shell script):
>> >>
>> >> # START OF SCRIPT
>> >>
>> >> #/usr/bin/env bash
>> >> changed_files="$(git diff-tree -r --name-only --no-commit-id ORIG_HEAD
>> >> HEAD)"
>> >>
>> >> check_run() {
>> >> echo "$changed_files" | grep --quiet "$1" && eval "$2"
>> >> }
>> >>
>> >> check_run .*.sql "say 'Found new delta. Please run it'" # on OSX this
>> will
>> >> literary speak out these words, fix as needed
>> >>
>> >> # END OF SCRIPT
>> >>
>> >> Acknowledgement: I did not invent this but reused this from Sindre
>> Sorhus
>> >> of sindresorhus.com
>> >>
>> >> Change filenames and regexes as needed. This will run everytime one
>> does a
>> >> git pull (not fetch, it runs post merging a remote/local branch to
>> >> master/current branch).
>> >>
>> >> Hope this helps.
>> >>
>> >>
>> >> On Tue, Jun 24, 2014 at 2:48 PM, Daan Hoogland <daan.hoogland@gmail.com
>> >
>> >> wrote:
>> >>
>> >>> including the source release? I don't like:( I do agree that some kind
>> >>> of guard would help, though
>> >>>
>> >>> On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam <ts...@apache.org>
>> >>> wrote:
>> >>> > On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
>> >>> >> It should be included in any release
>> >>> >>
>> >>> > so packaging can bring it back i thought. just a thought.
>> >>> > --
>> >>> > Prasanna.,
>> >>> >
>> >>> > ------------------------
>> >>> > Powered by BigRock.com
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Daan
>> >>>
>> >
>> >
>> >
>> > --
>> > Daan
>>
Re: create_schema.sql
Posted by Rohit Yadav <ro...@gmail.com>.
On Sat, Jun 28, 2014 at 2:43 AM, David Nalley <da...@gnsa.us> wrote:
> we could always add it to .gitignore
> That wouldn't stop changes from being made, but it would stop changes
> from propagating to the repo itself.
>
But David, one can git add -f or something. Can we put a git hook (post
commit/push) on the ASF repo if possible which could send us an alert email
when certain files are changed?
Daan, we could have a cron job that checks this for us and alert us on
email if certain files are changed? Here something like Herald could work
which triggers alerts when code changes pass a complex condition (changing
of file, or code etc.) [1]
[1] http://phabricator.org/applications/herald/
Regards.
>
> On Fri, Jun 27, 2014 at 5:05 PM, Daan Hoogland <da...@gmail.com>
> wrote:
> > Rohit, sorry for the late reaction. this works for defending yourself
> > and maybe we should all do it, it doesn't defend the repo from
> > checkins. I would prefer that.
> >
> > On Tue, Jun 24, 2014 at 10:07 PM, Rohit Yadav <ro...@gmail.com>
> wrote:
> >> Hi Daan and others,
> >>
> >> Let me share a way to guard files that interest us by alerting us using
> the
> >> following shell script git hook:
> >>
> >> Put the following your .git/hooks/post-merge (make sure to chmod +x the
> >> following shell script):
> >>
> >> # START OF SCRIPT
> >>
> >> #/usr/bin/env bash
> >> changed_files="$(git diff-tree -r --name-only --no-commit-id ORIG_HEAD
> >> HEAD)"
> >>
> >> check_run() {
> >> echo "$changed_files" | grep --quiet "$1" && eval "$2"
> >> }
> >>
> >> check_run .*.sql "say 'Found new delta. Please run it'" # on OSX this
> will
> >> literary speak out these words, fix as needed
> >>
> >> # END OF SCRIPT
> >>
> >> Acknowledgement: I did not invent this but reused this from Sindre
> Sorhus
> >> of sindresorhus.com
> >>
> >> Change filenames and regexes as needed. This will run everytime one
> does a
> >> git pull (not fetch, it runs post merging a remote/local branch to
> >> master/current branch).
> >>
> >> Hope this helps.
> >>
> >>
> >> On Tue, Jun 24, 2014 at 2:48 PM, Daan Hoogland <daan.hoogland@gmail.com
> >
> >> wrote:
> >>
> >>> including the source release? I don't like:( I do agree that some kind
> >>> of guard would help, though
> >>>
> >>> On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam <ts...@apache.org>
> >>> wrote:
> >>> > On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
> >>> >> It should be included in any release
> >>> >>
> >>> > so packaging can bring it back i thought. just a thought.
> >>> > --
> >>> > Prasanna.,
> >>> >
> >>> > ------------------------
> >>> > Powered by BigRock.com
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>> Daan
> >>>
> >
> >
> >
> > --
> > Daan
>
Re: create_schema.sql
Posted by Daan Hoogland <da...@gmail.com>.
good call, we'll have to remember to temporarily remove it as we start on 5.0
On Fri, Jun 27, 2014 at 11:13 PM, David Nalley <da...@gnsa.us> wrote:
> we could always add it to .gitignore
> That wouldn't stop changes from being made, but it would stop changes
> from propagating to the repo itself.
>
> On Fri, Jun 27, 2014 at 5:05 PM, Daan Hoogland <da...@gmail.com> wrote:
>> Rohit, sorry for the late reaction. this works for defending yourself
>> and maybe we should all do it, it doesn't defend the repo from
>> checkins. I would prefer that.
>>
>> On Tue, Jun 24, 2014 at 10:07 PM, Rohit Yadav <ro...@gmail.com> wrote:
>>> Hi Daan and others,
>>>
>>> Let me share a way to guard files that interest us by alerting us using the
>>> following shell script git hook:
>>>
>>> Put the following your .git/hooks/post-merge (make sure to chmod +x the
>>> following shell script):
>>>
>>> # START OF SCRIPT
>>>
>>> #/usr/bin/env bash
>>> changed_files="$(git diff-tree -r --name-only --no-commit-id ORIG_HEAD
>>> HEAD)"
>>>
>>> check_run() {
>>> echo "$changed_files" | grep --quiet "$1" && eval "$2"
>>> }
>>>
>>> check_run .*.sql "say 'Found new delta. Please run it'" # on OSX this will
>>> literary speak out these words, fix as needed
>>>
>>> # END OF SCRIPT
>>>
>>> Acknowledgement: I did not invent this but reused this from Sindre Sorhus
>>> of sindresorhus.com
>>>
>>> Change filenames and regexes as needed. This will run everytime one does a
>>> git pull (not fetch, it runs post merging a remote/local branch to
>>> master/current branch).
>>>
>>> Hope this helps.
>>>
>>>
>>> On Tue, Jun 24, 2014 at 2:48 PM, Daan Hoogland <da...@gmail.com>
>>> wrote:
>>>
>>>> including the source release? I don't like:( I do agree that some kind
>>>> of guard would help, though
>>>>
>>>> On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam <ts...@apache.org>
>>>> wrote:
>>>> > On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
>>>> >> It should be included in any release
>>>> >>
>>>> > so packaging can bring it back i thought. just a thought.
>>>> > --
>>>> > Prasanna.,
>>>> >
>>>> > ------------------------
>>>> > Powered by BigRock.com
>>>> >
>>>>
>>>>
>>>>
>>>> --
>>>> Daan
>>>>
>>
>>
>>
>> --
>> Daan
--
Daan
Re: create_schema.sql
Posted by David Nalley <da...@gnsa.us>.
we could always add it to .gitignore
That wouldn't stop changes from being made, but it would stop changes
from propagating to the repo itself.
On Fri, Jun 27, 2014 at 5:05 PM, Daan Hoogland <da...@gmail.com> wrote:
> Rohit, sorry for the late reaction. this works for defending yourself
> and maybe we should all do it, it doesn't defend the repo from
> checkins. I would prefer that.
>
> On Tue, Jun 24, 2014 at 10:07 PM, Rohit Yadav <ro...@gmail.com> wrote:
>> Hi Daan and others,
>>
>> Let me share a way to guard files that interest us by alerting us using the
>> following shell script git hook:
>>
>> Put the following your .git/hooks/post-merge (make sure to chmod +x the
>> following shell script):
>>
>> # START OF SCRIPT
>>
>> #/usr/bin/env bash
>> changed_files="$(git diff-tree -r --name-only --no-commit-id ORIG_HEAD
>> HEAD)"
>>
>> check_run() {
>> echo "$changed_files" | grep --quiet "$1" && eval "$2"
>> }
>>
>> check_run .*.sql "say 'Found new delta. Please run it'" # on OSX this will
>> literary speak out these words, fix as needed
>>
>> # END OF SCRIPT
>>
>> Acknowledgement: I did not invent this but reused this from Sindre Sorhus
>> of sindresorhus.com
>>
>> Change filenames and regexes as needed. This will run everytime one does a
>> git pull (not fetch, it runs post merging a remote/local branch to
>> master/current branch).
>>
>> Hope this helps.
>>
>>
>> On Tue, Jun 24, 2014 at 2:48 PM, Daan Hoogland <da...@gmail.com>
>> wrote:
>>
>>> including the source release? I don't like:( I do agree that some kind
>>> of guard would help, though
>>>
>>> On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam <ts...@apache.org>
>>> wrote:
>>> > On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
>>> >> It should be included in any release
>>> >>
>>> > so packaging can bring it back i thought. just a thought.
>>> > --
>>> > Prasanna.,
>>> >
>>> > ------------------------
>>> > Powered by BigRock.com
>>> >
>>>
>>>
>>>
>>> --
>>> Daan
>>>
>
>
>
> --
> Daan
Re: create_schema.sql
Posted by Daan Hoogland <da...@gmail.com>.
Rohit, sorry for the late reaction. this works for defending yourself
and maybe we should all do it, it doesn't defend the repo from
checkins. I would prefer that.
On Tue, Jun 24, 2014 at 10:07 PM, Rohit Yadav <ro...@gmail.com> wrote:
> Hi Daan and others,
>
> Let me share a way to guard files that interest us by alerting us using the
> following shell script git hook:
>
> Put the following your .git/hooks/post-merge (make sure to chmod +x the
> following shell script):
>
> # START OF SCRIPT
>
> #/usr/bin/env bash
> changed_files="$(git diff-tree -r --name-only --no-commit-id ORIG_HEAD
> HEAD)"
>
> check_run() {
> echo "$changed_files" | grep --quiet "$1" && eval "$2"
> }
>
> check_run .*.sql "say 'Found new delta. Please run it'" # on OSX this will
> literary speak out these words, fix as needed
>
> # END OF SCRIPT
>
> Acknowledgement: I did not invent this but reused this from Sindre Sorhus
> of sindresorhus.com
>
> Change filenames and regexes as needed. This will run everytime one does a
> git pull (not fetch, it runs post merging a remote/local branch to
> master/current branch).
>
> Hope this helps.
>
>
> On Tue, Jun 24, 2014 at 2:48 PM, Daan Hoogland <da...@gmail.com>
> wrote:
>
>> including the source release? I don't like:( I do agree that some kind
>> of guard would help, though
>>
>> On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam <ts...@apache.org>
>> wrote:
>> > On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
>> >> It should be included in any release
>> >>
>> > so packaging can bring it back i thought. just a thought.
>> > --
>> > Prasanna.,
>> >
>> > ------------------------
>> > Powered by BigRock.com
>> >
>>
>>
>>
>> --
>> Daan
>>
--
Daan
Re: create_schema.sql
Posted by Rohit Yadav <ro...@gmail.com>.
Hi Daan and others,
Let me share a way to guard files that interest us by alerting us using the
following shell script git hook:
Put the following your .git/hooks/post-merge (make sure to chmod +x the
following shell script):
# START OF SCRIPT
#/usr/bin/env bash
changed_files="$(git diff-tree -r --name-only --no-commit-id ORIG_HEAD
HEAD)"
check_run() {
echo "$changed_files" | grep --quiet "$1" && eval "$2"
}
check_run .*.sql "say 'Found new delta. Please run it'" # on OSX this will
literary speak out these words, fix as needed
# END OF SCRIPT
Acknowledgement: I did not invent this but reused this from Sindre Sorhus
of sindresorhus.com
Change filenames and regexes as needed. This will run everytime one does a
git pull (not fetch, it runs post merging a remote/local branch to
master/current branch).
Hope this helps.
On Tue, Jun 24, 2014 at 2:48 PM, Daan Hoogland <da...@gmail.com>
wrote:
> including the source release? I don't like:( I do agree that some kind
> of guard would help, though
>
> On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam <ts...@apache.org>
> wrote:
> > On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
> >> It should be included in any release
> >>
> > so packaging can bring it back i thought. just a thought.
> > --
> > Prasanna.,
> >
> > ------------------------
> > Powered by BigRock.com
> >
>
>
>
> --
> Daan
>
Re: create_schema.sql
Posted by Daan Hoogland <da...@gmail.com>.
including the source release? I don't like:( I do agree that some kind
of guard would help, though
On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam <ts...@apache.org> wrote:
> On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
>> It should be included in any release
>>
> so packaging can bring it back i thought. just a thought.
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com
>
--
Daan
Re: create_schema.sql
Posted by Prasanna Santhanam <ts...@apache.org>.
On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote:
> It should be included in any release
>
so packaging can bring it back i thought. just a thought.
--
Prasanna.,
------------------------
Powered by BigRock.com
Re: create_schema.sql
Posted by Daan Hoogland <da...@gmail.com>.
It should be included in any release
On Tue, Jun 24, 2014 at 10:44 AM, Prasanna Santhanam <ts...@apache.org> wrote:
> On Tue, Jun 24, 2014 at 10:27:56AM +0200, Hugo Trippaers wrote:
>> Dear committers,
>>
>>
>> When either committing or reviewing, please pay attention to the
>> fact the create_schema.sql should NOT be modified under any
>> circumstances. Since release 4.1 this file is considered frozen and
>> updates to the schema will be in the upgrade scripts for the
>> versions.
>>
>> At the moment a number of commits have been accepted that modify the
>> schema which we now have to clean up or revert.
>>
>> Please pay attention to this.
>
> How about removing the file from all release-branches as they are cut?
> That way any changes that went into create-schema.sql is never brought
> in to release branches. Whoever starts with CloudStack is expected to
> seed the schema while on master at least once?
>
>>
>>
>> Cheers,
>>
>> Hugo
>
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com
>
--
Daan
Re: create_schema.sql
Posted by Prasanna Santhanam <ts...@apache.org>.
On Tue, Jun 24, 2014 at 10:27:56AM +0200, Hugo Trippaers wrote:
> Dear committers,
>
>
> When either committing or reviewing, please pay attention to the
> fact the create_schema.sql should NOT be modified under any
> circumstances. Since release 4.1 this file is considered frozen and
> updates to the schema will be in the upgrade scripts for the
> versions.
>
> At the moment a number of commits have been accepted that modify the
> schema which we now have to clean up or revert.
>
> Please pay attention to this.
How about removing the file from all release-branches as they are cut?
That way any changes that went into create-schema.sql is never brought
in to release branches. Whoever starts with CloudStack is expected to
seed the schema while on master at least once?
>
>
> Cheers,
>
> Hugo
--
Prasanna.,
------------------------
Powered by BigRock.com