You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by giacomo <gi...@apache.org> on 2002/04/14 20:41:58 UTC
Re: cvs commit: jakarta-avalon-excalibur/all/src/scratchpad/org/apache/avalon/excalibur/i18n
BundleSelector.java
On 14 Apr 2002 donaldp@apache.org wrote:
> donaldp 02/04/13 21:06:39
>
> Modified: all/src/scratchpad/org/apache/avalon/excalibur/i18n
> BundleSelector.java
> Log:
> Made constant final
>
> Revision Changes Path
> 1.14 +2 -3 jakarta-avalon-excalibur/all/src/scratchpad/org/apache/avalon/excalibur/i18n/BundleSelector.java
>
> Index: BundleSelector.java
> ===================================================================
> RCS file: /home/cvs/jakarta-avalon-excalibur/all/src/scratchpad/org/apache/avalon/excalibur/i18n/BundleSelector.java,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -r1.13 -r1.14
> --- BundleSelector.java 7 Apr 2002 06:44:18 -0000 1.13
> +++ BundleSelector.java 14 Apr 2002 04:06:39 -0000 1.14
> @@ -23,16 +23,15 @@
> *
> * @author <a href="mailto:neeme@one.lv">Neeme Praks</a>
> * @author <a href="mailto:mengelhart@earthtrip.com">Mike Engelhart</a>
> - * @version $Id: BundleSelector.java,v 1.13 2002/04/07 06:44:18 donaldp Exp $
> + * @version $Id: BundleSelector.java,v 1.14 2002/04/14 04:06:39 donaldp Exp $
> */
> -
> public class BundleSelector
> extends ExcaliburComponentSelector
> {
> /**
> * The role implemented by an <code>BundleSelector</code>.
> */
> - public static String ROLE = BundleSelector.class.getName();
> + public static final String ROLE = BundleSelector.class.getName();
Just a dumb question: Is the role implemented by the BundleSelector
different than that of ExcaliburComponentSelector (I thought that
subclasses don't have to change the role of the super class as they
implement the same role)?
Giacomo
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-avalon-excalibur/all/src/scratchpad/org/apache/avalon/excalibur/i18n BundleSelector.java
Posted by Peter Donald <pe...@apache.org>.
> > Well technically classes should not have a ROLE string. Only interfaces
> > have a ROLE and all implementations of interface share same ROLE. So
> > neither ExcaliburComponentSelector nor BundleSelector should define ROLE
> > IMHO.
> >
> :)
>
> So why did the author/changer of BundleSelector choose to set a
> different ROLE (that's what I was looking to get an answer for)
No idea - I just made it final ;)
--
Cheers,
Peter Donald
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-avalon-excalibur/all/src/scratchpad/org/apache/avalon/excalibur/i18n
BundleSelector.java
Posted by giacomo <gi...@apache.org>.
On Mon, 15 Apr 2002, Peter Donald wrote:
> On Mon, 15 Apr 2002 04:41, giacomo wrote:
> > Just a dumb question: Is the role implemented by the BundleSelector
> > different than that of ExcaliburComponentSelector (I thought that
> > subclasses don't have to change the role of the super class as they
> > implement the same role)?
>
> Well technically classes should not have a ROLE string. Only interfaces have a
> ROLE and all implementations of interface share same ROLE. So neither
> ExcaliburComponentSelector nor BundleSelector should define ROLE IMHO.
:)
So why did the author/changer of BundleSelector choose to set a
different ROLE (that's what I was looking to get an answer for)
Giacomo
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-avalon-excalibur/all/src/scratchpad/org/apache/avalon/excalibur/i18n BundleSelector.java
Posted by Peter Donald <pe...@apache.org>.
On Mon, 15 Apr 2002 04:41, giacomo wrote:
> Just a dumb question: Is the role implemented by the BundleSelector
> different than that of ExcaliburComponentSelector (I thought that
> subclasses don't have to change the role of the super class as they
> implement the same role)?
Well technically classes should not have a ROLE string. Only interfaces have a
ROLE and all implementations of interface share same ROLE. So neither
ExcaliburComponentSelector nor BundleSelector should define ROLE IMHO.
--
Cheers,
Peter Donald
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>