You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by ra...@apache.org on 2017/02/28 00:03:57 UTC

[2/2] git commit: updated refs/heads/master to f9ef6ca

Merge pull request #1948 from greenqloud/pr-faster-static-nats

[CLOUDSTACK-9793] Faster IP in subnet checkThis change removes the conversion from IPNetwork to list in one of the router scripts. This makes the router faster at processing static NAT rules, which can prevent timeouts when attaching or detaching IPs.

With the `list` conversion, it has to potentially check a list of 65536 IP strings multiple times. We assume that the comparison implemented in the IPNetwork is far more efficient. We have seen speed-up from 218 seconds to enable static NAT with 18 IPs on the router to 2 or 3 seconds by removing this cast. This also fixes a potential bug where adding IPs to a router time out because the scripts are taking too long. 218 seconds, for example, is beyond the timeout on the KVM agent for script execution, and then all enableStaticNat operations will fail.

* pr/1948:
  CLOUDSTACK-9793: Faster ip in subnet check

Signed-off-by: Rajani Karuturi <ra...@accelerite.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f9ef6ca6
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f9ef6ca6
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f9ef6ca6

Branch: refs/heads/master
Commit: f9ef6ca667dd71402c1962dd7f0107b87e6b74e2
Parents: 3d78802 d5c5eb1
Author: Rajani Karuturi <ra...@accelerite.com>
Authored: Tue Feb 28 05:33:38 2017 +0530
Committer: Rajani Karuturi <ra...@accelerite.com>
Committed: Tue Feb 28 05:33:38 2017 +0530

----------------------------------------------------------------------
 systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------