You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/04 20:13:00 UTC

[GitHub] [beam] AnandInguva opened a new pull request, #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

AnandInguva opened a new pull request, #24883:
URL: https://github.com/apache/beam/pull/24883

   * Install sklearn < 1.20.0
   
   * fixup syntax
   
   
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371704560

   Run Python_PVR_Flink PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371372514

   Run Python 3.9 PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371371988

   R: @kennknowles 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371510568

   I don't think rebase is necessary. Can we rerun the GHA tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371703769

   Run Python PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371399886

   # [Codecov](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#24883](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (170e1ef) into [release-2.44.0](https://codecov.io/gh/apache/beam/commit/56a89733759079b3567ed6d2994380dc48728eef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56a8973) will **decrease** coverage by `0.55%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@                Coverage Diff                 @@
   ##           release-2.44.0   #24883      +/-   ##
   ==================================================
   - Coverage           73.92%   73.36%   -0.56%     
   ==================================================
     Files                 718      718              
     Lines              100046    97168    -2878     
   ==================================================
   - Hits                73955    71286    -2669     
   + Misses              24743    24534     -209     
     Partials             1348     1348              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `82.99% <ø> (-0.40%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.90% <0.00%> (-5.52%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/aws/s3io.py](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL3MzaW8ucHk=) | `84.42% <0.00%> (-5.00%)` | :arrow_down: |
   | [...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=) | `82.69% <0.00%> (-4.03%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | `27.01% <0.00%> (-3.47%)` | :arrow_down: |
   | [...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=) | `77.34% <0.00%> (-3.45%)` | :arrow_down: |
   | [sdks/python/apache\_beam/runners/render.py](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9yZW5kZXIucHk=) | `49.45% <0.00%> (-3.15%)` | :arrow_down: |
   | [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `93.96% <0.00%> (-1.77%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5) | `96.05% <0.00%> (-1.69%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/gcp/gcsio.py](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2lvLnB5) | `92.12% <0.00%> (-1.54%)` | :arrow_down: |
   | [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `95.46% <0.00%> (-0.95%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/beam/pull/24883?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371395336

   Okay. When we merge https://github.com/apache/beam/pull/24884, then the tests will pass on the release branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371373255

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles merged pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
kennknowles merged PR #24883:
URL: https://github.com/apache/beam/pull/24883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371387605

   I tried "re-run failed jobs" but the error didn't look like anything flaky...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371520035

   I'm not sure if it updates the merge commit that it runs against. I kicked them off. But it might just make sense to rebase this PR against the release-2.44.0 branch to be sure you've pulled in the latest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371389745

   ```
   × python setup.py egg_info did not run successfully.
     │ exit code: 1
     ╰─> [10 lines of output]
         Traceback (most recent call last):
           File "<string>", line 36, in <module>
           File "<pip-setuptools-caller>", line [34](https://github.com/apache/beam/actions/runs/3841272211/jobs/6541297299#step:6:35), in <module>
           File "/home/runner/work/beam/beam/sdks/python/target/.tox/py37/tmp/pip-req-build-ehxcjqv9/setup.py", line 180, in <module>
             generate_protos_first()
           File "/home/runner/work/beam/beam/sdks/python/target/.tox/py[37](https://github.com/apache/beam/actions/runs/3841272211/jobs/6541297299#step:6:38)/tmp/pip-req-build-ehxcjqv9/setup.py", line 150, in generate_protos_first
             gen_protos.generate_proto_files()
           File "/home/runner/work/beam/beam/sdks/python/target/.tox/py37/tmp/pip-req-build-ehxcjqv9/gen_protos.py", line 476, in generate_proto_files
             raise RuntimeError(error_msg)
         RuntimeError: Not in apache git tree, unable to find proto definitions.
         [end of output]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371390252

   I don't think it has anything to do with this pull request but is probably broken for the release branch entirely.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371704237

   Run Python 3.9 PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371378376

   It looks like there is some problem with the GitHub Actions. Does it look familiar?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371390580

   I think I encountered this issue and created a PR that resolved this. Another cherry-pick should be made


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371508632

   I merged the other one - rebase this one now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24883: [release-2.44.0]Install sklearn < 1.20.0 for sklearn postcommit tests (#24788)

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24883:
URL: https://github.com/apache/beam/pull/24883#issuecomment-1371521032

   okay. I will rebase and ping you again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org