You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ac...@apache.org on 2020/10/12 16:24:33 UTC
[camel-kafka-connector] 01/05: Remove public modifier on JUnit 5
methods
This is an automated email from the ASF dual-hosted git repository.
acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git
commit e801dfe13c9d8903fd7b298ff2192394a9ae7d54
Author: Aurélien Pupier <ap...@redhat.com>
AuthorDate: Mon Oct 12 14:17:08 2020 +0200
Remove public modifier on JUnit 5 methods
this is a best practice recommended by Sonar. The public modifier was
mandatory with Junit4, it is no more the case with JUnit 5.
Signed-off-by: Aurélien Pupier <ap...@redhat.com>
---
.../kafkaconnector/catalog/CamelKafkaConnectorCatalogTest.java | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/camel-kafka-connector-catalog/src/test/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalogTest.java b/camel-kafka-connector-catalog/src/test/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalogTest.java
index bbbed25..38dd791 100644
--- a/camel-kafka-connector-catalog/src/test/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalogTest.java
+++ b/camel-kafka-connector-catalog/src/test/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalogTest.java
@@ -26,24 +26,23 @@ import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
-public class CamelKafkaConnectorCatalogTest {
+class CamelKafkaConnectorCatalogTest {
static CamelKafkaConnectorCatalog catalog;
-
- @BeforeAll
+ @BeforeAll
public static void createCamelCatalog() {
catalog = new CamelKafkaConnectorCatalog();
}
@Test
- public void testConnectors() throws Exception {
+ void testConnectors() throws Exception {
List<String> list = catalog.getConnectorsName();
assertTrue(list.contains("camel-aws2-s3-sink"));
assertTrue(list.contains("camel-aws2-s3-source"));
}
@Test
- public void testOptions() throws Exception {
+ void testOptions() throws Exception {
Map<String, CamelKafkaConnectorModel> p = catalog.getConnectorsModel();
CamelKafkaConnectorModel model = p.get("camel-aws2-s3-sink");
assertEquals("org.apache.camel.kafkaconnector", model.getGroupId());