You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Honghua Feng (JIRA)" <ji...@apache.org> on 2014/05/19 12:15:38 UTC
[jira] [Commented] (HBASE-11200) AsyncWriter of FSHLog might throw
ArrayIndexOutOfBoundsException
[ https://issues.apache.org/jira/browse/HBASE-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001561#comment-14001561 ]
Honghua Feng commented on HBASE-11200:
--------------------------------------
lgtm, +1
> AsyncWriter of FSHLog might throw ArrayIndexOutOfBoundsException
> ----------------------------------------------------------------
>
> Key: HBASE-11200
> URL: https://issues.apache.org/jira/browse/HBASE-11200
> Project: HBase
> Issue Type: Bug
> Components: wal
> Affects Versions: 0.98.2
> Reporter: cuijianwei
> Assignee: cuijianwei
> Priority: Minor
> Attachments: HBASE-11200-0.98.patch
>
>
> AsyncWriter of FSHLog might throw ArrayIndexOutOfBoundsException because of the following code in AsyncWriter#run():
> {code}
> }
> }
> if (!hasIdleSyncer) {
> int idx = (int)this.lastWrittenTxid % asyncSyncers.length;
> asyncSyncers[idx].setWrittenTxid(this.lastWrittenTxid);
> }
> }
> {code}
> In obove code, "this.lastWrittenTxid % asyncSyncers.length" might become negative when this.lastWrittenTxid is bigger than Interger.MAX_VALUE where this.lastWrittenTxid is a long. The attachment gives a quick fix.
--
This message was sent by Atlassian JIRA
(v6.2#6252)