You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by xi...@apache.org on 2018/12/19 05:02:36 UTC
asterixdb git commit: [NO ISSUE][EXT] Fix JRecord setField for open
fields
Repository: asterixdb
Updated Branches:
refs/heads/master c7c8fffdf -> 9b4027cc5
[NO ISSUE][EXT] Fix JRecord setField for open fields
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
setField method should be able to handle open fields.
Change-Id: I4ec185d62e78e8100215334bc656586268314797
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3068
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ali Alsuliman <al...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/asterixdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/asterixdb/commit/9b4027cc
Tree: http://git-wip-us.apache.org/repos/asf/asterixdb/tree/9b4027cc
Diff: http://git-wip-us.apache.org/repos/asf/asterixdb/diff/9b4027cc
Branch: refs/heads/master
Commit: 9b4027cc5cce44b218852720127c02aedfa780e8
Parents: c7c8fff
Author: Xikui Wang <xk...@gmail.com>
Authored: Wed Dec 19 06:58:58 2018 +0800
Committer: Xikui Wang <xk...@gmail.com>
Committed: Tue Dec 18 21:01:56 2018 -0800
----------------------------------------------------------------------
.../keyword_detector/keyword_detector.1.ddl.sqlpp | 3 +--
.../org/apache/asterix/external/library/java/base/JRecord.java | 6 +-----
2 files changed, 2 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/asterixdb/blob/9b4027cc/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
index 4402130..464ecb2 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
@@ -35,8 +35,7 @@ dept:string
};
create type DetectResultType as open{
-id:int64,
-sensitive: boolean
+id:int64
};
create dataset EmpDataset(InputRecordType) primary key id;
http://git-wip-us.apache.org/repos/asf/asterixdb/blob/9b4027cc/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
index 7fa9d0b..10c228d 100644
--- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
+++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
@@ -99,11 +99,7 @@ public final class JRecord implements IJObject {
if (pos >= 0) {
fields[pos] = fieldValue;
} else {
- if (openFields.get(fieldName) != null) {
- openFields.put(fieldName, fieldValue);
- } else {
- throw new RuntimeDataException(ErrorCode.LIBRARY_JAVA_JOBJECTS_UNKNOWN_FIELD, fieldName);
- }
+ openFields.put(fieldName, fieldValue);
}
}