[GitHub] [incubator-mxnet] xinyu-intel commented on a change in pull request #15230: Updating SymbolBlock.imports to support different dtypes

[GitBox <gi...@apache.org>]

xinyu-intel commented on a change in pull request #15230: Updating SymbolBlock.imports to support different dtypes
URL: https://github.com/apache/incubator-mxnet/pull/15230#discussion_r293216173
 
 

 ##########
 File path: tests/python/unittest/test_gluon.py
 ##########
 @@ -2750,6 +2775,17 @@ def test_gluon_param_load():
     net.cast('float16')
     net.load_parameters('test_gluon_param_load.params', cast_dtype=True)
     mx.nd.waitall()
+    
+@with_seed()
+def test_gluon_param_load_dtype_source():
+    net = mx.gluon.nn.Dense(10, in_units=10)
+    net.initialize()
+    net.cast('float16')
 
 Review comment:
   Also suggest for adding test for loading int8 weight. BTW, I just took a quick try and this works well with my internal patch:)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services