You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/04/22 11:07:34 UTC
[GitHub] [hadoop] steveloughran commented on a change in pull request #2945: HADOOP-17653. Do not use guava's Files.createTempDir().
steveloughran commented on a change in pull request #2945:
URL: https://github.com/apache/hadoop/pull/2945#discussion_r618302465
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/blockaliasmap/impl/TestLevelDbMockAliasMapClient.java
##########
@@ -16,7 +16,7 @@
*/
package org.apache.hadoop.hdfs.server.common.blockaliasmap.impl;
-import org.apache.hadoop.thirdparty.com.google.common.io.Files;
+import org.apache.hadoop.test.GenericTestUtils;
Review comment:
nit: move to ~the right ordering in the list
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/blockaliasmap/impl/TestInMemoryLevelDBAliasMapClient.java
##########
@@ -16,8 +16,8 @@
*/
package org.apache.hadoop.hdfs.server.common.blockaliasmap.impl;
+import org.apache.hadoop.test.GenericTestUtils;
Review comment:
nit: move down to the real o.a.h imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org