You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/21 20:33:34 UTC

[GitHub] [airflow] KKcorps opened a new pull request #6874: [AIRFLOW-6076] Fix dag.cli() Key error

KKcorps opened a new pull request #6874: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6874
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6076
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
    The DAG cli subcommands are nested inside the main command. The dictionary only contained the main commands and not the nested commands. This resulted in the KeyError.
   Also, some of the DAG subcommands in `dag_subparsers` had names referring to older version.
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
    Tests are already present
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #6874: [AIRFLOW-6076] Fix dag.cli() Key error

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6874: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6874#issuecomment-568212421
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6874?src=pr&el=h1) Report
   > Merging [#6874](https://codecov.io/gh/apache/airflow/pull/6874?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6bc4165ff3d3588ec5dc802f411e071adf80cb3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6874/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6874?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6874      +/-   ##
   ==========================================
   - Coverage   84.61%   84.33%   -0.29%     
   ==========================================
     Files         680      680              
     Lines       38501    38505       +4     
   ==========================================
   - Hits        32578    32472     -106     
   - Misses       5923     6033     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6874?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6874/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `95.83% <100%> (+0.24%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6874/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6874/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6874/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6874/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6874/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6874?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6874?src=pr&el=footer). Last update [a6bc416...9b95d45](https://codecov.io/gh/apache/airflow/pull/6874?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] KKcorps closed pull request #6874: [AIRFLOW-6076] Fix dag.cli() Key error

Posted by GitBox <gi...@apache.org>.
KKcorps closed pull request #6874: [AIRFLOW-6076] Fix dag.cli() Key error
URL: https://github.com/apache/airflow/pull/6874
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services