You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/22 13:02:39 UTC
[GitHub] [airflow] ashb opened a new pull request #18432: De-dup and reorganize render template tests
ashb opened a new pull request #18432:
URL: https://github.com/apache/airflow/pull/18432
- test_render_template_fields_native_envs duplicated the existing
test_retest_render_template_with_native_envs
- Testing dag settings (user_defined_*) was testing the behaviour of
Jinja2. The test has bee streamlined and moved to test_dag (where the
jinija env is created)
- Tests of the undefined behaviour have been removed as it is just
testing Jinja behaviour, moved to just testing property of env in
test_dag.
- Removed neededless DAG creation
- Used BaseOperator instead of DummyOperator
- Used existing MockOperator class instead of file-local CustomOp
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #18432: De-dup and reorganize render template tests
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #18432:
URL: https://github.com/apache/airflow/pull/18432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #18432: De-dup and reorganize render template tests
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #18432:
URL: https://github.com/apache/airflow/pull/18432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18432: De-dup and reorganize render template tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18432:
URL: https://github.com/apache/airflow/pull/18432#issuecomment-925411437
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18432: De-dup and reorganize render template tests
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18432:
URL: https://github.com/apache/airflow/pull/18432#issuecomment-927252113
```
tests/models/test_dag.py::TestDag::test_template_undefined: TypeError: test_template_undefined() missing 1 required positional argument: 'value'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #18432: De-dup and reorganize render template tests
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #18432:
URL: https://github.com/apache/airflow/pull/18432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org