You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2021/01/03 18:50:38 UTC
[GitHub] [karaf-decanter] paulsp opened a new pull request #221: [KARAF-6983] Add property "replaceDotsByUnderscores" to the configura…
paulsp opened a new pull request #221:
URL: https://github.com/apache/karaf-decanter/pull/221
[KARAF-6983] Add property "replaceDotsByUnderscores" to the configuration file
- Create the org.apache.karaf.decanter.marshaller.json.cfg for the JsonMarshaller
- Add property "replaceDotsByUnderscores" with the default value to the config file
- Add unit tests for the property
- Add the config file to the assembly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-decanter] paulsp commented on pull request #221: [KARAF-6983] Add property "replaceDotsByUnderscores" to the configura…
Posted by GitBox <gi...@apache.org>.
paulsp commented on pull request #221:
URL: https://github.com/apache/karaf-decanter/pull/221#issuecomment-756754886
@jbonofre What is the status of this request, specifically will the request be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-decanter] paulsp commented on pull request #221: [KARAF-6983] Add property "replaceDotsByUnderscores" to the configura…
Posted by GitBox <gi...@apache.org>.
paulsp commented on pull request #221:
URL: https://github.com/apache/karaf-decanter/pull/221#issuecomment-756754886
@jbonofre What is the status of this request, specifically will the request be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-decanter] jbonofre commented on pull request #221: [KARAF-6983] Add property "replaceDotsByUnderscores" to the configura…
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #221:
URL: https://github.com/apache/karaf-decanter/pull/221#issuecomment-756786933
@paulsp I agree to merge it. I will do it ! Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-decanter] paulsp commented on pull request #221: [KARAF-6983] Add property "replaceDotsByUnderscores" to the configura…
Posted by GitBox <gi...@apache.org>.
paulsp commented on pull request #221:
URL: https://github.com/apache/karaf-decanter/pull/221#issuecomment-754017357
JB, I found this configuration property in the source code while configuring Alerting rules and noticed the rules were not catching events. The events originated from decanter-collector-oshi and the field names contains one or more dots. I was using decanter-appender-file with JSON formatting to identify the field names, which resulted in using the wrong field name. Only after digging into the source code did I find the property.
The option to replace the dot with an underscore was added in v2.1.0 by [KARAF-5793] and that was to accommodate changes to ElasticSearch. The title of the issue includes the phrase "Provide an option replace", but nowhere outside of the issue is the property documented.
The point of this PR is to make the property visible within the configuration files, even if 99% of the user base never changed the property value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-decanter] jbonofre commented on pull request #221: [KARAF-6983] Add property "replaceDotsByUnderscores" to the configura…
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #221:
URL: https://github.com/apache/karaf-decanter/pull/221#issuecomment-756786933
@paulsp I agree to merge it. I will do it ! Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-decanter] jbonofre commented on pull request #221: [KARAF-6983] Add property "replaceDotsByUnderscores" to the configura…
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #221:
URL: https://github.com/apache/karaf-decanter/pull/221#issuecomment-753753963
I'm not sure about this PR as the purpose is to have the config file as optional for marshaller (most of users don't have to change it). Let me think about that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-decanter] jbonofre merged pull request #221: [KARAF-6983] Add property "replaceDotsByUnderscores" to the configura…
Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #221:
URL: https://github.com/apache/karaf-decanter/pull/221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-decanter] jbonofre commented on pull request #221: [KARAF-6983] Add property "replaceDotsByUnderscores" to the configura…
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #221:
URL: https://github.com/apache/karaf-decanter/pull/221#issuecomment-754018411
@paulsp yes, I understand, and I think it makes sense. It's more a "documentation" purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org