You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jdye64 (via GitHub)" <gi...@apache.org> on 2023/02/06 14:26:43 UTC
[GitHub] [arrow-datafusion-python] jdye64 opened a new pull request, #171: Pyo3 bump
jdye64 opened a new pull request, #171:
URL: https://github.com/apache/arrow-datafusion-python/pull/171
# Which issue does this PR close?
Closes #140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #171: Pyo3 bump
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #171:
URL: https://github.com/apache/arrow-datafusion-python/pull/171#discussion_r1098078653
##########
Cargo.toml:
##########
@@ -33,12 +33,12 @@ default = ["mimalloc"]
[dependencies]
tokio = { version = "1.24", features = ["macros", "rt", "rt-multi-thread", "sync"] }
rand = "0.8"
-pyo3 = { version = "~0.17.3", features = ["extension-module", "abi3", "abi3-py37"] }
-datafusion = { version = "17.0.0", features = ["pyarrow", "avro"] }
-datafusion-expr = "17.0.0"
-datafusion-optimizer = "17.0.0"
-datafusion-common = { version = "17.0.0", features = ["pyarrow"] }
-datafusion-substrait = "17.0.0"
+pyo3 = { version = "0.18.0", features = ["extension-module", "abi3", "abi3-py37"] }
+datafusion = { git="https://github.com/apache/arrow-datafusion.git", branch="master", features = ["pyarrow", "avro"] }
Review Comment:
Could we pin to a specific rev here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] jdye64 commented on a diff in pull request #171: Pyo3 bump
Posted by "jdye64 (via GitHub)" <gi...@apache.org>.
jdye64 commented on code in PR #171:
URL: https://github.com/apache/arrow-datafusion-python/pull/171#discussion_r1098090298
##########
Cargo.toml:
##########
@@ -33,12 +33,12 @@ default = ["mimalloc"]
[dependencies]
tokio = { version = "1.24", features = ["macros", "rt", "rt-multi-thread", "sync"] }
rand = "0.8"
-pyo3 = { version = "~0.17.3", features = ["extension-module", "abi3", "abi3-py37"] }
-datafusion = { version = "17.0.0", features = ["pyarrow", "avro"] }
-datafusion-expr = "17.0.0"
-datafusion-optimizer = "17.0.0"
-datafusion-common = { version = "17.0.0", features = ["pyarrow"] }
-datafusion-substrait = "17.0.0"
+pyo3 = { version = "0.18.0", features = ["extension-module", "abi3", "abi3-py37"] }
+datafusion = { git="https://github.com/apache/arrow-datafusion.git", branch="master", features = ["pyarrow", "avro"] }
Review Comment:
Yes, I had it that way from the start and changed by to `branch=master` for some reason I no longer remember?? Anyway, just pinned it to a release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove merged pull request #171: Pyo3 bump
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #171:
URL: https://github.com/apache/arrow-datafusion-python/pull/171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] jdye64 commented on pull request #171: Pyo3 bump
Posted by "jdye64 (via GitHub)" <gi...@apache.org>.
jdye64 commented on PR #171:
URL: https://github.com/apache/arrow-datafusion-python/pull/171#issuecomment-1419189805
@andygrove this failure seems to be around the recent `execution_plan` changes you made. Any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org