You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2023/06/07 07:40:07 UTC
[GitHub] [camel-k] squakez opened a new issue, #4466: Rework CLIs required by operator build process
squakez opened a new issue, #4466:
URL: https://github.com/apache/camel-k/issues/4466
Leftover from original #4326
There are certain dependencies that are required by CLIs used by internal development tooling:
- github.com/shurcooL/httpfs v0.0.0-20190707220628-8d4bc4ba7749
- github.com/shurcooL/vfsgen v0.0.0-20181202132449-6a9ea43bcacd
- gengo
In #4326 we tried to remove the tools in ''/cmd` directory but it turns out they are required. Goal of this issue is to rework those tools and either remove their usage or use supported dependencies in order to have a safer maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on issue #4466: Rework CLIs required by operator build process
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on issue #4466:
URL: https://github.com/apache/camel-k/issues/4466#issuecomment-1609075255
The real solution for this issue is solving #3384. We need to switch to the standard `go:embed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on issue #4466: Rework CLIs required by operator build process
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on issue #4466:
URL: https://github.com/apache/camel-k/issues/4466#issuecomment-1608962801
@squakez I will work on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on issue #4466: Rework CLIs required by operator build process
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on issue #4466:
URL: https://github.com/apache/camel-k/issues/4466#issuecomment-1609537812
The resources.go stores files as byte representation for late retrieval, for example in master.go trait `data, err := resources.TemplateResource(fmt.Sprintf("/addons/master/%s", name), params)` it loads the embedded file.
See the list of embedded files
```
resources/traits.yaml
resources/builder/builder-service-account.yaml
resources/builder/builder-role.yaml
resources/builder/builder-role-binding.yaml
resources/builder/builder-role-binding-openshift.yaml
resources/builder/builder-role-openshift.yaml
resources/camel-catalog-2.16.0-SNAPSHOT.yaml
resources/addons/master/master-role-configmap.tmpl
resources/addons/master/master-role-lease.tmpl
resources/addons/master/master-role-binding.tmpl
resources/viewer/user-global-platform-viewer-role-binding.yaml
resources/viewer/user-global-kamelet-viewer-role-binding.yaml
resources/viewer/user-global-platform-viewer-role.yaml
resources/viewer/user-global-kamelet-viewer-role.yaml
```
I think they can be replaced by `go:embed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #4466: Rework CLIs required by operator build process
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #4466:
URL: https://github.com/apache/camel-k/issues/4466#issuecomment-1609094247
Good for spotting it. I'm closing this in favor of the one you've identified. If you're still working on it, let me know and I'll assign it to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez closed issue #4466: Rework CLIs required by operator build process
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez closed issue #4466: Rework CLIs required by operator build process
URL: https://github.com/apache/camel-k/issues/4466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #4466: Rework CLIs required by operator build process
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #4466:
URL: https://github.com/apache/camel-k/issues/4466#issuecomment-1580113091
cc @gansheer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #4466: Rework CLIs required by operator build process
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #4466:
URL: https://github.com/apache/camel-k/issues/4466#issuecomment-1609094732
> The real solution for this issue is solving #3384. We need to switch to the standard `go:embed`.
>
> That brings me this question: what is the resources.go usage, why do we need it ?
Not really sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org