[jira] Issue Comment Edited: (PDFBOX-519) NullPointerException in SetNonStrokingSeparation.java

["Andrew Duffy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752660#action_12752660 ] 

Andrew Duffy edited comment on PDFBOX-519 at 9/8/09 11:38 AM:
--------------------------------------------------------------

I did more investigation. For a display a separation works by passing a tint value between 0 and 1 to a transformation function to get components of an alternate colour space.

PDSeparation.getColorValues assumes that the tint function is a type 2 function always returns the value for a tint of 1.0 (it returns the value of C1 from the tint transformation function).

I've attached a patch to PDSeparation.java that throws an exception if the function is not type 2 rather than retuning null.

In theory, it should be possible to interpolate for the tint value for a type 2 function; type 0 seems relatively easy as well.

      was (Author: andrew_duffy):
    I did more investigation. For a display a separation works by passing a tint value between 0 and 1 to a transformation function to get components of an alternate colour space.

PDSeparation.getColorValues assumes that the tint function is a type 2 function always returns the value for a tint of 1.0 (it returns the value of C1 from the tint transformation function).

I've attached a new patch (to PDSeparation.java; the old patch is incorrect) that throws an exception if the function is not type 2.
  
> NullPointerException in SetNonStrokingSeparation.java
> -----------------------------------------------------
>
>                 Key: PDFBOX-519
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-519
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>    Affects Versions: 0.8.0-incubator
>            Reporter: Andrew Duffy
>            Priority: Minor
>         Attachments: npe.patch
>
>
> Caused by a failure to check for a null return from PDSeparation.getColorValues()
> java.lang.NullPointerException
>  	at org.apache.pdfbox.util.operator.SetNonStrokingSeparation.process(SetNonStrokingSeparation.java:56)
>  	at org.apache.pdfbox.util.operator.SetStrokingColor.process(SetStrokingColor.java:78)
>  	at org.apache.pdfbox.util.PDFStreamEngine.processOperator(PDFStreamEngine.java:510)
>  	at org.apache.pdfbox.util.PDFStreamEngine.processSubStream(PDFStreamEngine.java:223)
>  	at org.apache.pdfbox.util.PDFStreamEngine.processStream(PDFStreamEngine.java:182)
>  	at org.apache.pdfbox.pdfviewer.PageDrawer.drawPage(PageDrawer.java:92)
>  	at org.apache.pdfbox.pdmodel.PDPage.convertToImage(PDPage.java:686)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.