You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/09/22 18:42:32 UTC
[kudu-CR] [test] add 'do {} while ()' for NO PENDING FATALS
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14278
Change subject: [test] add 'do {} while ()' for NO_PENDING_FATALS
......................................................................
[test] add 'do {} while ()' for NO_PENDING_FATALS
This patch adds 'do {} while ()' scope around the definition of the
NO_PENDING_FATALS macro, unifying it with others from test_macros.h.
The motivation for this change was seeing warnings on an empty statement
generated by QtCreator IDE.
Change-Id: Icc97db2b761fec44bfa8b45f81210fb09124b866
---
M src/kudu/util/test_macros.h
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/14278/1
--
To view, visit http://gerrit.cloudera.org:8080/14278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc97db2b761fec44bfa8b45f81210fb09124b866
Gerrit-Change-Number: 14278
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [test] add 'do {} while ()' for NO PENDING FATALS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14278 )
Change subject: [test] add 'do {} while ()' for NO_PENDING_FATALS
......................................................................
[test] add 'do {} while ()' for NO_PENDING_FATALS
This patch adds 'do {} while ()' scope around the definition of the
NO_PENDING_FATALS macro, unifying it with others from test_macros.h.
The motivation for this change was seeing warnings on an empty statement
generated by QtCreator IDE.
Change-Id: Icc97db2b761fec44bfa8b45f81210fb09124b866
Reviewed-on: http://gerrit.cloudera.org:8080/14278
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/test_macros.h
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc97db2b761fec44bfa8b45f81210fb09124b866
Gerrit-Change-Number: 14278
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [test] add 'do {} while ()' for NO PENDING FATALS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14278 )
Change subject: [test] add 'do {} while ()' for NO_PENDING_FATALS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc97db2b761fec44bfa8b45f81210fb09124b866
Gerrit-Change-Number: 14278
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Sep 2019 00:12:54 +0000
Gerrit-HasComments: No