You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stricklandrbls (via GitHub)" <gi...@apache.org> on 2023/08/21 15:34:01 UTC
[GitHub] [daffodil-vscode] stricklandrbls opened a new pull request, #822: Fixed Multiple Data Editor Editing / Display Items
stricklandrbls opened a new pull request, #822:
URL: https://github.com/apache/daffodil-vscode/pull/822
- Fixed issue where binary display radix would still display 16 bytes per row, instead of 8.
- Fixed inability to edit a "non-regular" sized file ( file size < 2 )
- Rerouted all file / viewport UI offset traversal to use toplevel `seek()` function.
Closes #821
Closes #783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on pull request #822: Fixed Multiple Data Editor Editing / Display Items
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on PR #822:
URL: https://github.com/apache/daffodil-vscode/pull/822#issuecomment-1686975282
> I have a 1-byte file with the ASCII character `x`. If I edit that byte, replacing the `x` with a `y`: <img alt="Screen Shot 2023-08-21 at 12 04 16 PM" width="1143" src="https://user-images.githubusercontent.com/31163/262128192-c104230d-748c-4427-935e-c7fd232eb416.png"> then "Apply changes" (btw, I had no idea what the icon was), I get the context `yx`: <img alt="Screen Shot 2023-08-21 at 12 05 15 PM" width="1138" src="https://user-images.githubusercontent.com/31163/262128818-f6480cf5-9da6-43a7-9b40-c55d98c6d213.png"> I'm expecting to get only `y`.
Just pushed a commit that I believe fixes that issue and an issue w/ overwrite only while the file size if irregular.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien merged pull request #822: Fixed Multiple Data Editor Editing / Display Items
Posted by "arosien (via GitHub)" <gi...@apache.org>.
arosien merged PR #822:
URL: https://github.com/apache/daffodil-vscode/pull/822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien commented on pull request #822: Fixed Multiple Data Editor Editing / Display Items
Posted by "arosien (via GitHub)" <gi...@apache.org>.
arosien commented on PR #822:
URL: https://github.com/apache/daffodil-vscode/pull/822#issuecomment-1686900975
Binary display radix shows 8 bytes per row ✔️
<img width="1141" alt="Screen Shot 2023-08-21 at 12 18 17 PM" src="https://github.com/apache/daffodil-vscode/assets/31163/160b3078-914c-4525-a52b-1996754b660d">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien commented on pull request #822: Fixed Multiple Data Editor Editing / Display Items
Posted by "arosien (via GitHub)" <gi...@apache.org>.
arosien commented on PR #822:
URL: https://github.com/apache/daffodil-vscode/pull/822#issuecomment-1686874457
I have a 1-byte file with the ASCII character `x`. If I edit that byte, replacing the `x` with a `y`:
<img width="1143" alt="Screen Shot 2023-08-21 at 12 04 16 PM" src="https://github.com/apache/daffodil-vscode/assets/31163/c104230d-748c-4427-935e-c7fd232eb416">
then "Apply changes" (btw, I had no idea what the icon was), I get the context `yx`:
<img width="1138" alt="Screen Shot 2023-08-21 at 12 05 15 PM" src="https://github.com/apache/daffodil-vscode/assets/31163/f6480cf5-9da6-43a7-9b40-c55d98c6d213">
I'm expecting to get only `y`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org