[GitHub] [helix] jiajunwang commented on issue #392: Implement Cluster Model Provider.

[GitBox <gi...@apache.org>]

jiajunwang commented on issue #392: Implement Cluster Model Provider.
URL: https://github.com/apache/helix/pull/392#issuecomment-519805485
 
 
   @pkuwm Thanks for the comment.
   But for the formatting, let's update our style file instead of manual change every file. Please feel free to take the issue https://github.com/apache/helix/issues/349.
   
   Note that our regulation requires every developer to format the code based on the style file. The codes you reviewed are that result.
   I agree that it can be improved. But even I manually change it, whenever I format the code, it will be reverted back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org