You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/07/31 23:56:55 UTC
Re: Review Request 67444: Made quota consumption tracking
event-driven in the allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67444/
-----------------------------------------------------------
(Updated July 31, 2018, 4:56 p.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
Made quota consumption tracking event-driven in the allocator.
Bugs: MESOS-8802
https://issues.apache.org/jira/browse/MESOS-8802
Repository: mesos
Description (updated)
-------
The allocator needs to keep track of role consumed quota
to maintain quota headroom. Currently this info is
constructed on the fly prior to each allocation cycle.
This patch lets the allocator track quota consumption
across allocation cycles in an event-driven manner to improve
performance and reduce code complexity.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 0cd2fac17f09110c46b8540523a9c935f156f858
src/master/allocator/mesos/hierarchical.cpp 35992474eacb8b14ae57e1dc23307e1542f63cb5
Diff: https://reviews.apache.org/r/67444/diff/2/
Changes: https://reviews.apache.org/r/67444/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67444: Made quota consumption tracking
event-driven in the allocator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67444/#review212998
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 68118.
Failed command: `python.exe .\support\apply-reviews.py -n -r 68118`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2914/mesos-review-67444
Relevant logs:
- [apply-review-68118.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2914/mesos-review-67444/logs/apply-review-68118.log):
```
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:523
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On July 31, 2018, 11:56 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67444/
> -----------------------------------------------------------
>
> (Updated July 31, 2018, 11:56 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8802
> https://issues.apache.org/jira/browse/MESOS-8802
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator needs to keep track of role consumed quota
> to maintain quota headroom. Currently this info is
> constructed on the fly prior to each allocation cycle.
>
> This patch lets the allocator track quota consumption
> across allocation cycles in an event-driven manner to improve
> performance and reduce code complexity.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 0cd2fac17f09110c46b8540523a9c935f156f858
> src/master/allocator/mesos/hierarchical.cpp 35992474eacb8b14ae57e1dc23307e1542f63cb5
>
>
> Diff: https://reviews.apache.org/r/67444/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67444: Made quota consumption tracking
event-driven in the allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67444/#review213114
-----------------------------------------------------------
Bad review!
Reviews applied: [67444, 68119, 68118]
Error:
2019-02-23 07:31:48 URL:https://reviews.apache.org/r/68118/diff/raw/ [11126/11126] -> "68118.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:523
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
- Mesos Reviewbot
On July 31, 2018, 4:56 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67444/
> -----------------------------------------------------------
>
> (Updated July 31, 2018, 4:56 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8802
> https://issues.apache.org/jira/browse/MESOS-8802
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator needs to keep track of role consumed quota
> to maintain quota headroom. Currently this info is
> constructed on the fly prior to each allocation cycle.
>
> This patch lets the allocator track quota consumption
> across allocation cycles in an event-driven manner to improve
> performance and reduce code complexity.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 0cd2fac17f09110c46b8540523a9c935f156f858
> src/master/allocator/mesos/hierarchical.cpp 35992474eacb8b14ae57e1dc23307e1542f63cb5
>
>
> Diff: https://reviews.apache.org/r/67444/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>