You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by calvinjia <gi...@git.apache.org> on 2015/03/03 04:38:54 UTC

[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

GitHub user calvinjia opened a pull request:

    https://github.com/apache/spark/pull/4867

    [SPARK-6122][Core] Upgrade Tachyon client version to 0.6.0.

    Changes the Tachyon client version from 0.5 to 0.6 in spark core and distribution script.
    
    New dependencies in Tachyon 0.6.0 include
    
    commons-codec:commons-codec:jar:1.5:compile
    io.netty:netty-all:jar:4.0.23.Final:compile
    
    These are already in spark core.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/calvinjia/spark upgrade_tachyon_0.6.0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/4867.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4867
    
----
commit 71bf4413ea58cb0d8bcd14d8c6f84c4a7fdbcc6a
Author: Calvin Jia <ji...@gmail.com>
Date:   2015-03-03T03:08:37Z

    Upgrade Tachyon client version to 0.6.0.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by calvinjia <gi...@git.apache.org>.
Github user calvinjia commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-83159034
  
    @haoyuan @pwendell @aarondav
    
    I've updated the version to the recently released 0.6.1. The dependency info is the same and the api has not changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by calvinjia <gi...@git.apache.org>.
Github user calvinjia commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-88985837
  
    @srowen @syepes I'm planning to re-open this when Tachyon 0.6.2 is available. There were two problems encountered in the tests:
    
    1. HTTPClient version mismatch: Selenium (used for UI tests) requires version 4.3.x, and Tachyon included 4.2.5 through a transitive dependency of its shaded thrift jar. To address this, Tachyon 0.6.2 will promote the transitive dependencies of the shaded jar so they can be excluded in spark.
    
    2. Jackson-Mapper-ASL version mismatch: In lower versions of hadoop-client (ie. 1.0.4), version 1.0.1 is included. The parquet library used in spark sql requires version 1.8+. Its unclear to me why upgrading tachyon-client would cause this dependency to break. The solution was to exclude jackson-mapper-asl from hadoop-client. If there is a better way to handle this issue, please let me know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77501032
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28323/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by syepes <gi...@git.apache.org>.
Github user syepes commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-88892098
  
    is there any change this PR will get merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77494293
  
      [Test build #28323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28323/consoleFull) for   PR 4867 at commit [`11907b3`](https://github.com/apache/spark/commit/11907b34e4b70a640944164b9db66cf507f3918c).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-85183514
  
    The master SBT build is currently broken for a few Hadoop profiles due to dependency issues.  Do you think that this patch may have been responsible?  I noticed that it wasn't tested by Jenkins prior to being merged (the last test was 18 days ago with an earlier version of the patch).  See https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/1940/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-85246645
  
    Patrick reverted this patch in 6cd7058b369ec8d01938961f148734ee9eaf76de and it appears that reverting it has fixed the builds: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/1947/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by haoyuan <gi...@git.apache.org>.
Github user haoyuan commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77006434
  
    @aarondav @pwendell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-88895453
  
    @syepes I think the problem would have to be fixed no? you can try applying the patch an examining what changes about dependencies in the builds that broke. Narrowing it down that much may help everyone understand how to fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by calvinjia <gi...@git.apache.org>.
Github user calvinjia commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77078619
  
    @zzcclp Tachyon client has a new api so I will update the relevant spark code and test before reopening this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by calvinjia <gi...@git.apache.org>.
Github user calvinjia commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-85237240
  
    @srowen Oh I see the build still failed after the fix to that patch. Strange that there would be issues between now and the last test run for this patch since there should not have been any dependency changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by calvinjia <gi...@git.apache.org>.
Github user calvinjia commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77242143
  
    @aarondav @pwendell 
    I've updated the client interface and tested it with basic count/wordcount and off heap storage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by calvinjia <gi...@git.apache.org>.
GitHub user calvinjia reopened a pull request:

    https://github.com/apache/spark/pull/4867

    [SPARK-6122][Core] Upgrade Tachyon client version to 0.6.0.

    Changes the Tachyon client version from 0.5 to 0.6 in spark core and distribution script.
    
    New dependencies in Tachyon 0.6.0 include
    
    commons-codec:commons-codec:jar:1.5:compile
    io.netty:netty-all:jar:4.0.23.Final:compile
    
    These are already in spark core.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/calvinjia/spark upgrade_tachyon_0.6.0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/4867.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4867
    
----
commit 71bf4413ea58cb0d8bcd14d8c6f84c4a7fdbcc6a
Author: Calvin Jia <ji...@gmail.com>
Date:   2015-03-03T03:08:37Z

    Upgrade Tachyon client version to 0.6.0.

commit 11907b34e4b70a640944164b9db66cf507f3918c
Author: Calvin Jia <ji...@gmail.com>
Date:   2015-03-04T03:18:46Z

    Use TachyonURI for tachyon paths instead of strings.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77106164
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-76881727
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by haoyuan <gi...@git.apache.org>.
Github user haoyuan commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77493363
  
    jenkins, test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77078291
  
    why to close this RP?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-85282854
  
    The build only broke when compiled against other versions of Hadoop, so
    it's likely that some of the dependency changes overwrote the deps of other
    Hadoop versions.
    
    On Mon, Mar 23, 2015 at 4:34 PM, Josh Rosen <no...@github.com>
    wrote:
    
    > Patrick reverted this patch in 6cd7058
    > <https://github.com/apache/spark/commit/6cd7058b369ec8d01938961f148734ee9eaf76de>
    > and it appears that reverting it has fixed the builds:
    > https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/1947/
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/spark/pull/4867#issuecomment-85246645>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by haoyuan <gi...@git.apache.org>.
Github user haoyuan commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77493854
  
    Jenkins, test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by calvinjia <gi...@git.apache.org>.
Github user calvinjia commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-85234685
  
    @JoshRosen Just from a quick glance at the output log, it seems to be a style issue (line > 100 characters). I don't think this patch should have caused the issues, since the errors have been the same as the ones since build #1937.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/4867


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by calvinjia <gi...@git.apache.org>.
Github user calvinjia closed the pull request at:

    https://github.com/apache/spark/pull/4867


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by haoyuan <gi...@git.apache.org>.
Github user haoyuan commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77493071
  
    Ok to test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-84200925
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-84137739
  
    LGTM.
    
    @pwendell Since this touches Spark's dependencies, would you like to sign off?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-84668071
  
    Merged into master, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-85236153
  
    @calvinjia yup this was fall-out from my mistake yesterday at https://github.com/apache/spark/pull/5128/files It's already patched thanks to Reynold, so that should be fine now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4867#issuecomment-77501026
  
      [Test build #28323 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28323/consoleFull) for   PR 4867 at commit [`11907b3`](https://github.com/apache/spark/commit/11907b34e4b70a640944164b9db66cf507f3918c).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org