You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/07/27 07:11:30 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
HappenLee opened a new pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329
1. FE vecrizied plan code
2. Function register vec function
3. Diff function nullable type
4. New thirdpart code and new thirt struct
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If these changes need document changes, I have updated the document
- [x] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee commented on pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#issuecomment-896630144
@francisoliverlee yes，but it only contain the some interface of vec-engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r679765883
##########
File path: be/src/exec/exec_node.h
##########
@@ -46,6 +45,11 @@ class TupleRow;
class DataSink;
class MemTracker;
+namespace vectorized {
+class Block;
Review comment:
Just keep the interface for compile be code do not contain the real code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r679766893
##########
File path: be/src/exec/schema_scanner.cpp
##########
@@ -127,7 +127,11 @@ Status SchemaScanner::create_tuple_desc(ObjectPool* pool) {
for (int i = 0; i < _column_num; ++i) {
TSlotDescriptor t_slot_desc;
- t_slot_desc.__set_slotType(TypeDescriptor(_columns[i].type).to_thrift());
+ if (_columns[i].type == TYPE_DECIMALV2) {
+ t_slot_desc.__set_slotType(TypeDescriptor::create_decimalv2_type(27, 9).to_thrift());
Review comment:
Now, Doris do not really use the `precision` and `scale` in BE, so here need to a TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
wangbo commented on pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#issuecomment-887318632
> 3. Diff function nullable type
> 4. New thirdpart code and new thirt struct
What does point 3 and point 4 specifically refer to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
hf200012 commented on pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#issuecomment-896630964
Great, I look forward to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r684620291
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java
##########
@@ -1020,12 +1121,21 @@ private void initAggregateBuiltins() {
// count(*)
addBuiltin(AggregateFunction.createBuiltin(FunctionSet.COUNT,
new ArrayList<Type>(), Type.BIGINT, Type.BIGINT,
- prefix + "9init_zeroIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
+ prefix + "18init_zero_not_nullIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
Review comment:
yes, to keep count slot not null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#issuecomment-896630120
> @HappenLee does those 2 PR all of implementation of ver-engine?
>
> 
Not yet, more PR will coming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo edited a comment on pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
wangbo edited a comment on pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#issuecomment-887318632
> 3. Diff function nullable type
> 4. New thirdpart code and new thirt struct
What does point 3 and point 4 specifically refer to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r683194583
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java
##########
@@ -17,6 +17,9 @@
package org.apache.doris.analysis;
+import java.util.Arrays;
+import java.util.Map;
Review comment:
import order
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/CompoundPredicate.java
##########
@@ -17,6 +17,9 @@
package org.apache.doris.analysis;
+import com.google.common.collect.Lists;
Review comment:
import order
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java
##########
@@ -1020,12 +1121,21 @@ private void initAggregateBuiltins() {
// count(*)
addBuiltin(AggregateFunction.createBuiltin(FunctionSet.COUNT,
new ArrayList<Type>(), Type.BIGINT, Type.BIGINT,
- prefix + "9init_zeroIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
+ prefix + "18init_zero_not_nullIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
Review comment:
changed?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java
##########
@@ -1037,12 +1147,21 @@ private void initAggregateBuiltins() {
// Count
addBuiltin(AggregateFunction.createBuiltin(FunctionSet.COUNT,
Lists.newArrayList(t), Type.BIGINT, Type.BIGINT,
- prefix + "9init_zeroIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
+ prefix + "18init_zero_not_nullIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
Review comment:
changed?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/FeMetaVersion.java
##########
@@ -216,6 +216,8 @@
public static final int VERSION_101 = 101;
// add data encrypt
public static final int VERSION_102 = 102;
+ // add vectorized to function
+ public static final int VERSION_103 = 103;
Review comment:
Not used?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java
##########
@@ -1479,7 +1845,7 @@ private void initAggregateBuiltins() {
prefix + "13rank_finalizeEPN9doris_udf15FunctionContextERNS1_9StringValE"));
addBuiltin(AggregateFunction.createAnalyticBuiltin( "row_number",
new ArrayList<Type>(), Type.BIGINT, Type.BIGINT,
- prefix + "9init_zeroIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
+ prefix + "18init_zero_not_nullIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
Review comment:
changed?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/AggregateFunction.java
##########
@@ -20,6 +20,7 @@
import static org.apache.doris.common.io.IOUtils.readOptionStringOrNull;
import static org.apache.doris.common.io.IOUtils.writeOptionString;
+import avro.shaded.com.google.common.collect.ImmutableSet;
Review comment:
wrong import
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Function.java
##########
@@ -640,6 +664,9 @@ public void readFields(DataInput input) throws IOException {
if (hasChecksum) {
checksum = Text.readString(input);
}
+ if (Catalog.getCurrentCatalogJournalVersion() >= FeMetaVersion.VERSION_101) {
Review comment:
remove meta version
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Function.java
##########
@@ -104,40 +117,49 @@
private HdfsURI location;
private TFunctionBinaryType binaryType;
+ protected NullableMode nullableMode = NullableMode.DEPEND_ON_ARGUMENT;
+
+ private boolean vectorized;
Review comment:
```suggestion
private boolean vectorized = false;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
wangbo commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r677260058
##########
File path: be/src/exec/schema_scanner.cpp
##########
@@ -127,7 +127,11 @@ Status SchemaScanner::create_tuple_desc(ObjectPool* pool) {
for (int i = 0; i < _column_num; ++i) {
TSlotDescriptor t_slot_desc;
- t_slot_desc.__set_slotType(TypeDescriptor(_columns[i].type).to_thrift());
+ if (_columns[i].type == TYPE_DECIMALV2) {
+ t_slot_desc.__set_slotType(TypeDescriptor::create_decimalv2_type(27, 9).to_thrift());
Review comment:
Why hard code ```precision``` and ```scale``` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
wangbo commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r677255107
##########
File path: be/src/exec/exec_node.h
##########
@@ -46,6 +45,11 @@ class TupleRow;
class DataSink;
class MemTracker;
+namespace vectorized {
+class Block;
Review comment:
Where does class ```Block``` come from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] francisoliverlee commented on pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#issuecomment-896628307
@HappenLee does those 2 PR all of implementation of ver-engine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] francisoliverlee commented on pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#issuecomment-896759349
> > @HappenLee does those 2 PR all of implementation of ver-engine?
> > 
>
> Not yet, more PR will coming.
that's nice, waiting...o_o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r683194583
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java
##########
@@ -17,6 +17,9 @@
package org.apache.doris.analysis;
+import java.util.Arrays;
+import java.util.Map;
Review comment:
import order
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/CompoundPredicate.java
##########
@@ -17,6 +17,9 @@
package org.apache.doris.analysis;
+import com.google.common.collect.Lists;
Review comment:
import order
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java
##########
@@ -1020,12 +1121,21 @@ private void initAggregateBuiltins() {
// count(*)
addBuiltin(AggregateFunction.createBuiltin(FunctionSet.COUNT,
new ArrayList<Type>(), Type.BIGINT, Type.BIGINT,
- prefix + "9init_zeroIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
+ prefix + "18init_zero_not_nullIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
Review comment:
changed?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java
##########
@@ -1037,12 +1147,21 @@ private void initAggregateBuiltins() {
// Count
addBuiltin(AggregateFunction.createBuiltin(FunctionSet.COUNT,
Lists.newArrayList(t), Type.BIGINT, Type.BIGINT,
- prefix + "9init_zeroIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
+ prefix + "18init_zero_not_nullIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
Review comment:
changed?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/FeMetaVersion.java
##########
@@ -216,6 +216,8 @@
public static final int VERSION_101 = 101;
// add data encrypt
public static final int VERSION_102 = 102;
+ // add vectorized to function
+ public static final int VERSION_103 = 103;
Review comment:
Not used?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java
##########
@@ -1479,7 +1845,7 @@ private void initAggregateBuiltins() {
prefix + "13rank_finalizeEPN9doris_udf15FunctionContextERNS1_9StringValE"));
addBuiltin(AggregateFunction.createAnalyticBuiltin( "row_number",
new ArrayList<Type>(), Type.BIGINT, Type.BIGINT,
- prefix + "9init_zeroIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
+ prefix + "18init_zero_not_nullIN9doris_udf9BigIntValEEEvPNS2_15FunctionContextEPT_",
Review comment:
changed?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/AggregateFunction.java
##########
@@ -20,6 +20,7 @@
import static org.apache.doris.common.io.IOUtils.readOptionStringOrNull;
import static org.apache.doris.common.io.IOUtils.writeOptionString;
+import avro.shaded.com.google.common.collect.ImmutableSet;
Review comment:
wrong import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r683208575
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Function.java
##########
@@ -640,6 +664,9 @@ public void readFields(DataInput input) throws IOException {
if (hasChecksum) {
checksum = Text.readString(input);
}
+ if (Catalog.getCurrentCatalogJournalVersion() >= FeMetaVersion.VERSION_101) {
Review comment:
remove meta version
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Function.java
##########
@@ -104,40 +117,49 @@
private HdfsURI location;
private TFunctionBinaryType binaryType;
+ protected NullableMode nullableMode = NullableMode.DEPEND_ON_ARGUMENT;
+
+ private boolean vectorized;
Review comment:
```suggestion
private boolean vectorized = false;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r679822754
##########
File path: be/CMakeLists.txt
##########
@@ -704,3 +704,8 @@ install(FILES
${BASE_DIR}/../conf/odbcinst.ini
DESTINATION ${OUTPUT_DIR}/conf)
+
+get_property(dirs DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES)
Review comment:
yes, I will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] stdpain commented on a change in pull request #6329: [New Featrue] Support Vectorization Execution Engine Interface For Doris
Posted by GitBox <gi...@apache.org>.
stdpain commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r679799775
##########
File path: be/CMakeLists.txt
##########
@@ -704,3 +704,8 @@ install(FILES
${BASE_DIR}/../conf/odbcinst.ini
DESTINATION ${OUTPUT_DIR}/conf)
+
+get_property(dirs DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES)
Review comment:
may be we should remove cmake log ?
##########
File path: be/src/exprs/aggregate_functions.cpp
##########
@@ -1925,8 +1939,7 @@ DoubleVal AggregateFunctions::knuth_var_pop_finalize(FunctionContext* ctx,
}
DecimalV2Val AggregateFunctions::decimalv2_knuth_var_pop_finalize(FunctionContext* ctx,
- const StringVal& state_sv) {
- DCHECK(!state_sv.is_null);
+ const StringVal& state_sv) {
Review comment:
need a code format here?
##########
File path: build.sh
##########
@@ -84,7 +92,7 @@ fi
eval set -- "$OPTS"
-PARALLEL=$[$(nproc)/4+1]
+PARALLEL=$[$(nproc)+1]
Review comment:
set PARALLEL= $[$(nproc)/4+1]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org