You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cloudstack.apache.org by "Alena Prokharchyk (JIRA)" <ji...@apache.org> on 2014/07/25 18:36:39 UTC

[jira] [Resolved] (CLOUDSTACK-3621) NPE when registering an invalid template

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alena Prokharchyk resolved CLOUDSTACK-3621.
-------------------------------------------

    Resolution: Fixed

The bug used to happen because zoneId was translated to NULL by the dispatcher, and then later on TemplateAdapter was running into NPE when trying to translate zoneId to zoneId.longValue by referencing null object. 

Fixed with:

* refactoring work done by Antonio:

commit 447430c3df38c36d947c44c4aebd961d8cbb14c4
Author: Antonio Fornie <af...@schubergphilis.com> 2014-01-30 17:28:57
Committer: Daan Hoogland <da...@onecht.net> 2014-02-04 04:37:08

> NPE when registering an invalid template
> ----------------------------------------
>
>                 Key: CLOUDSTACK-3621
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3621
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: Future
>            Reporter: Prasanna Santhanam
>            Assignee: Alena Prokharchyk
>            Priority: Critical
>             Fix For: 4.5.0
>
>
> Used an invalid uuid in the registerTemplate call and ended up with the following NPE
> 2013-07-18 10:14:03,235 DEBUG [cloud.api.ApiDispatcher] (ApiServer-7:ctx-eb976040) Object entity uuid = bb62589e-e3cd-11e2-ad39-ea6434daa8ba does not exist in the database.
> 2013-07-18 10:14:03,235 INFO  [cloud.api.ApiServer] (ApiServer-7:ctx-eb976040) Unable to execute API command registertemplate due to invalid value. Invalid parameter ostypeid value=bb62589e-e3cd-11e2-ad39-ea6434daa8ba due to incorrect long value format, or entity does not exist or due to incorrect parameter annotation for the field in api cmd class.
> 2013-07-18 10:14:03,236 DEBUG [cloudstack.context.CallContext] (ApiServer-7:ctx-eb976040) Context removed CallContext[acct=1; user=1; session=eb976040-e59d-437a-ba25-eda9a4075286]
> 2013-07-18 10:14:11,625 DEBUG [cloudstack.context.CallContext] (ApiServer-8:ctx-809a4f40) Setting calling context: CallContext[acct=1; user=1; session=809a4f40-37e6-42a2-bce7-373985d7870a]
> 2013-07-18 10:14:11,640 ERROR [cloud.api.ApiServer] (ApiServer-8:ctx-809a4f40) unhandled exception executing api command: registerTemplate
> java.lang.NullPointerException
>     at com.cloud.template.TemplateAdapterBase.prepare(TemplateAdapterBase.java:128)
>     at com.cloud.template.TemplateAdapterBase.prepare(TemplateAdapterBase.java:235)
>     at com.cloud.template.HypervisorTemplateAdapter.prepare(HypervisorTemplateAdapter.java:112)
>     at com.cloud.template.TemplateManagerImpl.registerTemplate(TemplateManagerImpl.java:345)
>     at com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
>     at org.apache.cloudstack.api.command.user.template.RegisterTemplateCmd.execute(RegisterTemplateCmd.java:245)
>     at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
>     at com.cloud.api.ApiServer.queueCommand(ApiServer.java:532)
>     at com.cloud.api.ApiServer.handleRequest(ApiServer.java:376)
>     at com.cloud.api.ApiServer.handle(ApiServer.java:307)
>     at org.apache.http.protocol.HttpService.doService(HttpService.java:375)
>     at org.apache.http.protocol.HttpService.handleRequest(HttpService.java:290)
>     at com.cloud.api.ApiServer$WorkerTask.run(ApiServer.java:994)
>     at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
>     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
>     at java.lang.Thread.run(Thread.java:680)



--
This message was sent by Atlassian JIRA
(v6.2#6252)