You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/05/26 04:29:03 UTC
[GitHub] [incubator-inlong] gosonzhang opened a new pull request #475: [INLONG-618] Add unit tests for metastore.dao.entity.*
gosonzhang opened a new pull request #475:
URL: https://github.com/apache/incubator-inlong/pull/475
add unit test cases for metastore.dao.entity.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang merged pull request #475: [INLONG-618] Add unit tests for metastore.dao.entity.*
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #475:
URL: https://github.com/apache/incubator-inlong/pull/475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #475: [INLONG-618] Add unit tests for metastore.dao.entity.*
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #475:
URL: https://github.com/apache/incubator-inlong/pull/475#issuecomment-848811791
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#475](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2939fc) into [TUBEMQ-570](https://codecov.io/gh/apache/incubator-inlong/commit/8046ff95ea022c264500689a39a67609d9d1574d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8046ff9) will **increase** coverage by `3.98%`.
> The diff coverage is `43.68%`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## TUBEMQ-570 #475 +/- ##
================================================
+ Coverage 8.26% 12.24% +3.98%
- Complexity 555 948 +393
================================================
Files 304 303 -1
Lines 30975 30918 -57
Branches 4982 4966 -16
================================================
+ Hits 2560 3787 +1227
+ Misses 27907 26406 -1501
- Partials 508 725 +217
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/tubemq/corebase/utils/SettingValidUtils.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS91dGlscy9TZXR0aW5nVmFsaWRVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...bemq/server/master/metamanage/MetaDataManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9NZXRhRGF0YU1hbmFnZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...r/master/metamanage/metastore/TStoreConstants.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvVFN0b3JlQ29uc3RhbnRzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...amanage/metastore/dao/entity/BrokerConfEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ccm9rZXJDb25mRW50aXR5LmphdmE=) | `49.57% <0.00%> (+49.57%)` | :arrow_up: |
| [...manage/metastore/dao/entity/TopicDeployEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ub3BpY0RlcGxveUVudGl0eS5qYXZh) | `51.21% <15.38%> (+51.21%)` | :arrow_up: |
| [...r/bdbstore/bdbentitys/BdbClusterSettingEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvYmRic3RvcmUvYmRiZW50aXR5cy9CZGJDbHVzdGVyU2V0dGluZ0VudGl0eS5qYXZh) | `46.88% <21.05%> (+46.88%)` | :arrow_up: |
| [...etamanage/metastore/dao/entity/TopicPropGroup.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ub3BpY1Byb3BHcm91cC5qYXZh) | `60.08% <26.66%> (+43.12%)` | :arrow_up: |
| [...e/metastore/dao/entity/GroupConsumeCtrlEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Hcm91cENvbnN1bWVDdHJsRW50aXR5LmphdmE=) | `38.40% <28.57%> (+38.40%)` | :arrow_up: |
| [...anage/metastore/dao/entity/GroupResCtrlEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Hcm91cFJlc0N0cmxFbnRpdHkuamF2YQ==) | `42.94% <36.84%> (+42.94%)` | :arrow_up: |
| [...er/bdbstore/bdbentitys/BdbGroupFlowCtrlEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvYmRic3RvcmUvYmRiZW50aXR5cy9CZGJHcm91cEZsb3dDdHJsRW50aXR5LmphdmE=) | `40.52% <42.42%> (+40.52%)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8046ff9...f2939fc](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #475: [INLONG-618] Add unit tests for metastore.dao.entity.*
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #475:
URL: https://github.com/apache/incubator-inlong/pull/475#issuecomment-848811791
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#475](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b8dad4) into [TUBEMQ-570](https://codecov.io/gh/apache/incubator-inlong/commit/8046ff95ea022c264500689a39a67609d9d1574d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8046ff9) will **increase** coverage by `3.78%`.
> The diff coverage is `72.72%`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## TUBEMQ-570 #475 +/- ##
================================================
+ Coverage 8.26% 12.04% +3.78%
- Complexity 555 920 +365
================================================
Files 304 304
Lines 30975 30899 -76
Branches 4982 4969 -13
================================================
+ Hits 2560 3722 +1162
+ Misses 27907 26468 -1439
- Partials 508 709 +201
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/tubemq/corebase/utils/SettingValidUtils.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS91dGlscy9TZXR0aW5nVmFsaWRVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...bemq/server/master/metamanage/MetaDataManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9NZXRhRGF0YU1hbmFnZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...amanage/metastore/dao/entity/BrokerConfEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ccm9rZXJDb25mRW50aXR5LmphdmE=) | `49.15% <ø> (+49.15%)` | :arrow_up: |
| [...e/metastore/dao/entity/GroupConsumeCtrlEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Hcm91cENvbnN1bWVDdHJsRW50aXR5LmphdmE=) | `37.68% <33.33%> (+37.68%)` | :arrow_up: |
| [...er/metamanage/metastore/dao/entity/BaseEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9CYXNlRW50aXR5LmphdmE=) | `62.87% <64.28%> (+39.85%)` | :arrow_up: |
| [...anage/metastore/dao/entity/GroupResCtrlEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Hcm91cFJlc0N0cmxFbnRpdHkuamF2YQ==) | `42.33% <66.66%> (+42.33%)` | :arrow_up: |
| [...age/metastore/dao/entity/ClusterSettingEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9DbHVzdGVyU2V0dGluZ0VudGl0eS5qYXZh) | `60.43% <72.72%> (+60.43%)` | :arrow_up: |
| [...e/tubemq/server/common/statusdef/CleanPolType.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vc3RhdHVzZGVmL0NsZWFuUG9sVHlwZS5qYXZh) | `50.00% <75.00%> (ø)` | |
| [...tamanage/metastore/dao/entity/TopicCtrlEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ub3BpY0N0cmxFbnRpdHkuamF2YQ==) | `46.34% <86.66%> (+46.34%)` | :arrow_up: |
| [...etamanage/metastore/dao/entity/TopicPropGroup.java](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ub3BpY1Byb3BHcm91cC5qYXZh) | `60.44% <87.50%> (+43.48%)` | :arrow_up: |
| ... and [23 more](https://codecov.io/gh/apache/incubator-inlong/pull/475/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8046ff9...7b8dad4](https://codecov.io/gh/apache/incubator-inlong/pull/475?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org