[jira] [Commented] (MSHARED-1067) Improve the Reproducible Builds methods in Maven-Archiver

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHARED-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526403#comment-17526403 ] 

Michael Osipov commented on MSHARED-1067:
-----------------------------------------

What is the benefit here of {{Optional}} compared to {{null}}?

> Improve the Reproducible Builds methods in Maven-Archiver
> ---------------------------------------------------------
>
>                 Key: MSHARED-1067
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1067
>             Project: Maven Shared Components
>          Issue Type: Dependency upgrade
>          Components: maven-archiver
>    Affects Versions: maven-archiver-3.5.2
>            Reporter: Jorge Solórzano
>            Priority: Major
>
> Maven Archiver 3.5.0 introduces some methods to parse the timestamp and configure the reproducible builds in plexus-archiver.
> The proposal for improvement is to leverage Java 8 APIs and deprecate older methods.
>  # Deprecate the method
> {code:java}
> public Date parseOutputTimestamp( String outputTimestamp )
> {code}
> and introduce a new static method:
> {code:java}
> public static Optional<Instant> parseBuildOutputTimestamp( String outputTimestamp )
> {code}
> #  Deprecate the method
> {code:java}
> public Date configureReproducible( String outputTimestamp )
> {code}
> and introduce the method
> {code:java}
> public void configureReproducibleBuild( String outputTimestamp )
> {code}
> The new API return an Optional<Instant> parsing the timestamp using java.time.format.DateTimeFormatter#ISO_INSTANT.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)