[GitHub] [ratis] adoroszlai commented on a diff in pull request #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #722:
URL: https://github.com/apache/ratis/pull/722#discussion_r951460393


##########
.github/workflows/post-commit.yml:
##########
@@ -172,7 +172,7 @@ jobs:
           if: always()
   findbugs:
     name: findbugs
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:

Review Comment:
   @codings-dan looks like Findbugs has some problem with the Ubuntu 20.04 upgrade.  I guess it has to do with Java 11 being default Java version.
   
   ```suggestion
       runs-on: ubuntu-20.04
       steps:
         - name: Setup java
           uses: actions/setup-java@v1
           with:
             java-version: 8
   ```
   
   Can we try with Java 8?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org