You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by ku...@apache.org on 2020/11/24 18:28:55 UTC

[incubator-gobblin] branch master updated: [GOBBLIN-1323] wrap extractColumnListInQuery in RestApiExtractor

This is an automated email from the ASF dual-hosted git repository.

kuyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new fb5e40f  [GOBBLIN-1323] wrap extractColumnListInQuery in RestApiExtractor
fb5e40f is described below

commit fb5e40fcffa978fdde7e22efb851f73ddd7a3587
Author: Wenqin Wang <wn...@linkedin.com>
AuthorDate: Tue Nov 24 10:28:45 2020 -0800

    [GOBBLIN-1323] wrap extractColumnListInQuery in RestApiExtractor
    
    Closes #3156 from wenqinduke/master
---
 .../gobblin/source/extractor/extract/restapi/RestApiExtractor.java  | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/restapi/RestApiExtractor.java b/gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/restapi/RestApiExtractor.java
index b5fe56d..a4bb579 100644
--- a/gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/restapi/RestApiExtractor.java
+++ b/gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/restapi/RestApiExtractor.java
@@ -96,6 +96,10 @@ public abstract class RestApiExtractor extends QueryBasedExtractor<JsonArray, Js
     return dataQuery;
   }
 
+  protected List<String> extractColumnListInQuery(String query) {
+    return Utils.getColumnListFromQuery(query);
+  }
+
   @Override
   public void extractMetadata(String schema, String entity, WorkUnit workUnit) throws SchemaException {
     log.info("Extract Metadata using Rest Api");
@@ -104,7 +108,7 @@ public abstract class RestApiExtractor extends QueryBasedExtractor<JsonArray, Js
     List<String> columnListInQuery = null;
     JsonArray array = null;
     if (!Strings.isNullOrEmpty(inputQuery)) {
-      columnListInQuery = Utils.getColumnListFromQuery(inputQuery);
+      columnListInQuery = extractColumnListInQuery(inputQuery);
     }
 
     String excludedColumns = workUnitState.getProp(ConfigurationKeys.SOURCE_QUERYBASED_EXCLUDED_COLUMNS);