You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/02/12 12:18:58 UTC

[GitHub] flink pull request #5460: [FLINK-8475][config][docs] Integrate Algorithm opt...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5460

    [FLINK-8475][config][docs] Integrate Algorithm options

    ## What is the purpose of the change
    
    This PR ports the runtime algorithm ConfigConstants to `ConfigOptions` and integrates them into the configuration docs generator.
    
    ## Brief change log
    
    * runtime algorithm config constants to config options
    * integrate runtime algorithm configuration table into `config.md`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8475_algorithm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5460
    
----
commit 4d991f39823898b4385007a3ef445480f196efae
Author: zentol <ch...@...>
Date:   2018-01-30T13:06:30Z

    [FLINK-8475][config][docs] Integrate Algorithm options

----


---

[GitHub] flink issue #5460: [FLINK-8475][config][docs] Integrate Algorithm options

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5460
  
    Ah, nevermind that last comment, we can't remove them because it's `@Public` api.


---

[GitHub] flink pull request #5460: [FLINK-8475][config][docs] Integrate Algorithm opt...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5460


---

[GitHub] flink issue #5460: [FLINK-8475][config][docs] Integrate Algorithm options

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5460
  
    Looks good, but I think you can remove the unused entries from `ConfigConstants` now.


---

[GitHub] flink issue #5460: [FLINK-8475][config][docs] Integrate Algorithm options

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5460
  
    merging.


---