You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/28 12:42:14 UTC
[GitHub] [incubator-eventmesh] NewtonVan opened a new pull request, #2007: issue(1709): add NPE exception check
NewtonVan opened a new pull request, #2007:
URL: https://github.com/apache/incubator-eventmesh/pull/2007
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Cloese #<XXX>`.)
-->
Fixes #1709 .
### Motivation
The return value from a method is dereferenced without a null check, and the return value of that method is one that should generally be checked for null. This may lead to a NullPointerException when the code is executed.
### Modifications
- Use `Objects.requireNonNull` method to achieve a fail-fast style NPE check.
### Documentation
* Does this pull request introduce a new feature? (yes / no) no
* If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not applicable
* If a feature is not applicable for documentation, explain why? This is a minor issue that comes under code cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #2007: [ISSUE #1709]Possible null pointer dereference due to return value of called method [tcp client Session]
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #2007:
URL: https://github.com/apache/incubator-eventmesh/pull/2007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] NewtonVan commented on pull request #2007: issue(1709): add NPE exception check
Posted by GitBox <gi...@apache.org>.
NewtonVan commented on PR #2007:
URL: https://github.com/apache/incubator-eventmesh/pull/2007#issuecomment-1296714685
> @NewtonVan please solve the conflicts.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #2007: issue(1709): add NPE exception check
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #2007:
URL: https://github.com/apache/incubator-eventmesh/pull/2007#issuecomment-1296462309
@NewtonVan please solve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org