You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/07 05:54:30 UTC
[GitHub] [incubator-nuttx] ethanlcz commented on a diff in pull request #6949: usrsock:refine usrsock's architecture
ethanlcz commented on code in PR #6949:
URL: https://github.com/apache/incubator-nuttx/pull/6949#discussion_r964408774
##########
net/usrsock/usrsock_recvmsg.c:
##########
@@ -83,8 +83,9 @@ static uint16_t recvfrom_event(FAR struct net_driver_s *dev,
pstate->valuelen_nontrunc = conn->resp.valuelen_nontrunc;
}
- if (pstate->reqstate.result >= 0 ||
- pstate->reqstate.result == -EAGAIN)
+ if (!(flags & USRSOCK_EVENT_RECVFROM_AVAIL) &&
Review Comment:
I rever this change
##########
net/usrsock/usrsock_recvmsg.c:
##########
@@ -83,8 +83,9 @@ static uint16_t recvfrom_event(FAR struct net_driver_s *dev,
pstate->valuelen_nontrunc = conn->resp.valuelen_nontrunc;
}
- if (pstate->reqstate.result >= 0 ||
- pstate->reqstate.result == -EAGAIN)
+ if (!(flags & USRSOCK_EVENT_RECVFROM_AVAIL) &&
Review Comment:
I revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org