[GitHub] [arrow-datafusion] alamb commented on issue #4389: Proposal: Improve the join keys of logical plan

[GitBox <gi...@apache.org>]

alamb commented on issue #4389:
URL: https://github.com/apache/arrow-datafusion/issues/4389#issuecomment-1328240376

   I think this makes a lot of sense to me. Thank you @ygf11 . 
   
   I would suggest a few other fields as well:
   1. For equijoins as you propose
   2. For other predicates that must be evaluated in the join (for outer joins, these have special semantics)
   
   This design also extends naturally to adding other specialized join predicates in the future (eg. range joins)
   
   ```
   /// Join two logical plans on one or more join columns
   #[derive(Clone)]
   pub struct Join {
       ...
       /// Equijoin clause expressed as pairs of (left, right) join exprs
       pub equi_preds: Vec<(Expr,Expr)>,
   
       /// other (non equi) join predicates
       pub on_preds: Vec<Expr>,
      ...
   }
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org