You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2016/06/21 04:36:32 UTC

Review Request 49002: ATLAS-922: remove embedded atlas-application.properties

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49002/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-922
    https://issues.apache.org/jira/browse/ATLAS-922


Repository: atlas


Description
-------

remove embedded atlas-application.properties


Diffs
-----

  addons/hdfs-model/pom.xml f4033bc 
  catalog/pom.xml 8a49d3d 
  client/pom.xml 69b8731 
  common/src/main/java/org/apache/atlas/ApplicationProperties.java 48cb7a6 
  notification/pom.xml fc08115 
  pom.xml 1539922 
  repository/pom.xml 533e48b 
  typesystem/pom.xml c1f3fcd 
  typesystem/src/main/resources/atlas-application.properties 2bbcdcd 
  typesystem/src/test/resources/atlas-application.properties ba66ae5 
  webapp/pom.xml bc62f87 

Diff: https://reviews.apache.org/r/49002/diff/


Testing
-------

Verified that atlas-application.properties is not embedded in atlas-typesystem.jar and the application/hooks load atlas-application.properties from application's conf directory (in the CLASSPATH) - irrespective of where atlas jars appear in the CLASSPATH.


Thanks,

Madhan Neethiraj


Re: Review Request 49002: ATLAS-922: remove embedded atlas-application.properties

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49002/#review138793
-----------------------------------------------------------


Ship it!




Ship It!

- Hemanth Yamijala


On June 21, 2016, 6:20 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49002/
> -----------------------------------------------------------
> 
> (Updated June 21, 2016, 6:20 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-922
>     https://issues.apache.org/jira/browse/ATLAS-922
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> remove embedded atlas-application.properties
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/pom.xml 14c6090 
>   addons/hdfs-model/pom.xml f4033bc 
>   addons/hive-bridge/pom.xml dff93a9 
>   addons/sqoop-bridge/pom.xml 343bb4e 
>   addons/storm-bridge/pom.xml b1a7a9b 
>   catalog/pom.xml 8a49d3d 
>   client/pom.xml 69b8731 
>   common/src/main/java/org/apache/atlas/ApplicationProperties.java 48cb7a6 
>   notification/pom.xml fc08115 
>   pom.xml 1539922 
>   repository/pom.xml 533e48b 
>   typesystem/pom.xml c1f3fcd 
>   typesystem/src/main/resources/atlas-application.properties 2bbcdcd 
>   typesystem/src/test/resources/atlas-application.properties ba66ae5 
>   webapp/pom.xml e17f64d 
> 
> Diff: https://reviews.apache.org/r/49002/diff/
> 
> 
> Testing
> -------
> 
> Verified that atlas-application.properties is not embedded in atlas-typesystem.jar and the application/hooks load atlas-application.properties from application's conf directory (in the CLASSPATH) - irrespective of where atlas jars appear in the CLASSPATH.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 49002: ATLAS-922: remove embedded atlas-application.properties

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49002/
-----------------------------------------------------------

(Updated June 21, 2016, 6:20 a.m.)


Review request for atlas.


Changes
-------

Fix for IT failures in addon modules


Bugs: ATLAS-922
    https://issues.apache.org/jira/browse/ATLAS-922


Repository: atlas


Description
-------

remove embedded atlas-application.properties


Diffs (updated)
-----

  addons/falcon-bridge/pom.xml 14c6090 
  addons/hdfs-model/pom.xml f4033bc 
  addons/hive-bridge/pom.xml dff93a9 
  addons/sqoop-bridge/pom.xml 343bb4e 
  addons/storm-bridge/pom.xml b1a7a9b 
  catalog/pom.xml 8a49d3d 
  client/pom.xml 69b8731 
  common/src/main/java/org/apache/atlas/ApplicationProperties.java 48cb7a6 
  notification/pom.xml fc08115 
  pom.xml 1539922 
  repository/pom.xml 533e48b 
  typesystem/pom.xml c1f3fcd 
  typesystem/src/main/resources/atlas-application.properties 2bbcdcd 
  typesystem/src/test/resources/atlas-application.properties ba66ae5 
  webapp/pom.xml e17f64d 

Diff: https://reviews.apache.org/r/49002/diff/


Testing
-------

Verified that atlas-application.properties is not embedded in atlas-typesystem.jar and the application/hooks load atlas-application.properties from application's conf directory (in the CLASSPATH) - irrespective of where atlas jars appear in the CLASSPATH.


Thanks,

Madhan Neethiraj


Re: Review Request 49002: ATLAS-922: remove embedded atlas-application.properties

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49002/
-----------------------------------------------------------

(Updated June 21, 2016, 5:40 a.m.)


Review request for atlas.


Changes
-------

Fix for IT failure in webapp - atlas.conf path was incorrect


Bugs: ATLAS-922
    https://issues.apache.org/jira/browse/ATLAS-922


Repository: atlas


Description
-------

remove embedded atlas-application.properties


Diffs (updated)
-----

  addons/hdfs-model/pom.xml f4033bc 
  catalog/pom.xml 8a49d3d 
  client/pom.xml 69b8731 
  common/src/main/java/org/apache/atlas/ApplicationProperties.java 48cb7a6 
  notification/pom.xml fc08115 
  pom.xml 1539922 
  repository/pom.xml 533e48b 
  typesystem/pom.xml c1f3fcd 
  typesystem/src/main/resources/atlas-application.properties 2bbcdcd 
  typesystem/src/test/resources/atlas-application.properties ba66ae5 
  webapp/pom.xml bc62f87 

Diff: https://reviews.apache.org/r/49002/diff/


Testing
-------

Verified that atlas-application.properties is not embedded in atlas-typesystem.jar and the application/hooks load atlas-application.properties from application's conf directory (in the CLASSPATH) - irrespective of where atlas jars appear in the CLASSPATH.


Thanks,

Madhan Neethiraj