You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/07/01 20:09:26 UTC
[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4592: HBASE-27170 ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse
bbeaudreault commented on code in PR #4592:
URL: https://github.com/apache/hbase/pull/4592#discussion_r912226622
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/HBaseReferenceCounted.java:
##########
@@ -40,7 +40,7 @@ default boolean release(int increment) {
@Override
default HBaseReferenceCounted touch() {
- throw new UnsupportedOperationException();
+ return touch(null);
Review Comment:
this change just makes it 1 step easier to enable this for other subclasses, since they could just override `touch(Object hint)` below and get both. It's functionally equivalent to today, since both throw an exception at present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org