You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/17 23:29:49 UTC
[GitHub] [incubator-druid] jihoonson commented on a change in pull request
#8909: Optimize CachingLocalSegmentAllocator#getSequenceName
jihoonson commented on a change in pull request #8909: Optimize CachingLocalSegmentAllocator#getSequenceName
URL: https://github.com/apache/incubator-druid/pull/8909#discussion_r359083627
##########
File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/RangePartitionCachingLocalSegmentAllocatorTest.java
##########
@@ -141,6 +142,16 @@ public void allocatesCorrectShardSpecsForLastPartition()
testAllocate(row, interval, partitionNum, null);
}
+ @Test
+ public void test_getSequenceName_forIntervalAndRow_shouldUseISOFormatAndPartitionNumForRow()
Review comment:
Thanks for adding tests. I think we prefer to use a short but intuitive name for tests and add comments if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org