[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #3133: [ISSUE #3103] collapase Exception

["jonyangx (via GitHub)" <gi...@apache.org>]

jonyangx commented on code in PR #3133:
URL: https://github.com/apache/incubator-eventmesh/pull/3133#discussion_r1105412491


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/push/AsyncHTTPPushRequest.java:
##########
@@ -350,13 +349,7 @@ ClientRetCode processResponseContent(String content) {
                     handleMsgContext.getBizSeqNo(), handleMsgContext.getUniqueId(), content);
             }
             return ClientRetCode.FAIL;
-        } catch (JsonException e) {
-            if (MESSAGE_LOGGER.isWarnEnabled()) {
-                MESSAGE_LOGGER.warn("url:{}, bizSeqno:{}, uniqueId:{},  httpResponse:{}", currPushUrl,
-                    handleMsgContext.getBizSeqNo(), handleMsgContext.getUniqueId(), content);
-            }
-            return ClientRetCode.FAIL;
-        } catch (Throwable t) {
+        } catch (Throwable e) {

Review Comment:
   Suggest catch Exception and not Throwable. @Bannirui 
   eg.
   try {
   ......
   } catch (JsonException e) {
   
   } catch (Exception ex) {
   
   } 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org