You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/09 22:18:50 UTC

[GitHub] [trafficserver] randall opened a new pull request #6994: Adds null check

randall opened a new pull request #6994:
URL: https://github.com/apache/trafficserver/pull/6994


   This attempts to fix null pointer access introduced in 3ffd8acf0b5f3f6258270d8ffea1c28d9f412d9c


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop commented on pull request #6994: Adds null check

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #6994:
URL: https://github.com/apache/trafficserver/pull/6994#issuecomment-657822051


   Cherry-picked to v9.0.x branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall edited a comment on pull request #6994: Adds null check

Posted by GitBox <gi...@apache.org>.
randall edited a comment on pull request #6994:
URL: https://github.com/apache/trafficserver/pull/6994#issuecomment-656852423


   This is from runs on my laptop that are probably saturating my internet connection.
   
   Here's the history.
   
   ```
   history = {
       history = {
         [0] = {
           location = (file = "HttpSM.cc", func = "state_read_client_request_header", line = 620)
           event = 100
           reentrancy = 2
         }
         [1] = {
           location = (file = "HttpSM.cc", func = "state_api_callback", line = 1344)
           event = 60000
           reentrancy = 3
         }
         [2] = {
           location = (file = "HttpSM.cc", func = "state_api_callout", line = 1384)
           event = 60000
           reentrancy = 3
         }
         [3] = {
           location = (file = "HttpSM.cc", func = "set_next_state", line = 7412)
           event = 34463
           reentrancy = 3
         }
         [4] = {
           location = (file = "HttpSM.cc", func = "state_hostdb_lookup", line = 2250)
           event = 500
           reentrancy = 1
         }
         [5] = {
           location = (file = "HttpSM.cc", func = "set_next_state", line = 7446)
           event = 34463
           reentrancy = 1
         }
         [6] = {
           location = (file = "HttpSM.cc", func = "state_hostdb_reverse_lookup", line = 2297)
           event = 500
           reentrancy = 1
         }
         [7] = {
           location = (file = "HttpSM.cc", func = "set_next_state", line = 7452)
           event = 34463
           reentrancy = 1
         }
         [8] = {
           location = (file = "HttpCacheSM.cc", func = "state_cache_open_read", line = 100)
           event = 1103
           reentrancy = -31073
         }
         [9] = {
           location = (file = "HttpSM.cc", func = "state_cache_open_read", line = 2529)
           event = 1103
           reentrancy = 2
         }
         [10] = {
           location = (file = "HttpSM.cc", func = "state_api_callback", line = 1344)
           event = 60000
           reentrancy = 3
         }
         [11] = {
           location = (file = "HttpSM.cc", func = "state_api_callout", line = 1384)
           event = 60000
           reentrancy = 3
         }
         [12] = {
           location = (file = "HttpSM.cc", func = "set_next_state", line = 7561)
           event = 34463
           reentrancy = 3
         }
         [13] = {
           location = (file = "HttpCacheSM.cc", func = "state_cache_open_write", line = 160)
           event = 1108
           reentrancy = -31073
         }
         [14] = {
           location = (file = "HttpSM.cc", func = "state_cache_open_write", line = 2410)
           event = 1108
           reentrancy = 4
         }
         [15] = {
           location = (file = "HttpSM.cc", func = "set_next_state", line = 7458)
           event = 34463
           reentrancy = 4
         }
         [16] = {
           location = (file = "HttpSM.cc", func = "state_http_server_open", line = 1726)
           event = 201
           reentrancy = 5
         }
   ...
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall merged pull request #6994: Adds null check

Posted by GitBox <gi...@apache.org>.
randall merged pull request #6994:
URL: https://github.com/apache/trafficserver/pull/6994


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall commented on pull request #6994: Adds null check

Posted by GitBox <gi...@apache.org>.
randall commented on pull request #6994:
URL: https://github.com/apache/trafficserver/pull/6994#issuecomment-656852423


   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall commented on pull request #6994: Adds null check

Posted by GitBox <gi...@apache.org>.
randall commented on pull request #6994:
URL: https://github.com/apache/trafficserver/pull/6994#issuecomment-656378777


   This is the stack for the crash:
   ```
       frame #0: 0x0000000100115d7c traffic_server`Http1ServerSession::get_netvc(this=0x0000000000000000) const at Http1ServerSession.cc:211:10
       frame #1: 0x00000001000f3239 traffic_server`HttpSM::state_http_server_open(this=0x0000001ded10a240, event=201, data=0xffffffffffffffbf) at HttpSM.cc:1812:42
       frame #2: 0x00000001000e303a traffic_server`HttpSM::main_handler(this=0x0000001ded10a240, event=201, data=0xffffffffffffffbf) at HttpSM.cc:2618:5
       frame #3: 0x0000000100004f4f traffic_server`Continuation::handleEvent(this=0x0000001ded10a240, event=201, data=0xffffffffffffffbf) at I_Continuation.h:190:12
       frame #4: 0x00000001004b3f1d traffic_server`UnixNetVConnection::connectUp(this=0x000000217a43cf30, t=0x00000000099a4300, fd=-1) at UnixNetVConnection.cc:1280:25
       frame #5: 0x00000001004aae48 traffic_server`UnixNetProcessor::connect_re_internal(this=0x00000001006d9070, cont=0x0000001ded10a240, target=0x0000001ded10a978, opt=0x000000000b7de1f0) at UnixNetProcessor.cc:245:17
       frame #6: 0x0000000100037d60 traffic_server`NetProcessor::connect_re(this=0x00000001006d9070, cont=0x0000001ded10a240, addr=0x0000001ded10a978, opts=0x000000000b7de1f0) at P_UnixNetProcessor.h:62:49
       frame #7: 0x00000001000ec3ba traffic_server`HttpSM::do_http_server_open(this=0x0000001ded10a240, raw=false) at HttpSM.cc:5163:42
       frame #8: 0x0000000100109a0f traffic_server`HttpSM::set_next_state(this=0x0000001ded10a240) at HttpSM.cc:7485:5
       frame #9: 0x00000001000e713e traffic_server`HttpSM::call_transact_and_set_next_state(this=0x0000001ded10a240, f=0x0000000000000000)(HttpTransact::State*)) at HttpSM.cc:7288:3
       frame #10: 0x00000001000fa379 traffic_server`HttpSM::state_cache_open_write(this=0x0000001ded10a240, event=1108, data=0x0000001ded4cd4e0) at HttpSM.cc:2505:3
       frame #11: 0x00000001000e303a traffic_server`HttpSM::main_handler(this=0x0000001ded10a240, event=1108, data=0x0000001ded4cd4e0) at HttpSM.cc:2618:5
       frame #12: 0x0000000100004f4f traffic_server`Continuation::handleEvent(this=0x0000001ded10a240, event=1108, data=0x0000001ded4cd4e0) at I_Continuation.h:190:12
       frame #13: 0x00000001000949a4 traffic_server`HttpCacheSM::state_cache_open_write(this=0x0000001ded10c018, event=1108, data=0x0000001ded4cd4e0) at HttpCacheSM.cc:171:16
       frame #14: 0x0000000100004f4f traffic_server`Continuation::handleEvent(this=0x0000001ded10c018, event=1108, data=0x0000001ded4cd4e0) at I_Continuation.h:190:12
       frame #15: 0x000000010037a7c3 traffic_server`CacheVC::callcont(this=0x0000001ded4cd4e0, event=1108) at P_CacheInternal.h:639:25
       frame #16: 0x000000010037c646 traffic_server`Cache::open_write(this=0x0000001d782dbfd0, cont=0x0000001ded10c018, key=0x000000000b7df220, info=0x0000000000000000, apin_in_cache=0, (null)=0x0000000000000000, type=CACHE_FRAG_TYPE_HTTP, hostname="XXXX", host_len=4) at CacheWrite.cc:1824:6
       frame #17: 0x0000000100325f89 traffic_server`CacheProcessor::open_write(this=0x00000001006d7920, cont=0x0000001ded10c018, expected_size=0, key=0x000000000b7df210, request=0x0000001ded10a9f8, old_info=0x0000000000000000, pin_in_cache=0, type=CACHE_FRAG_TYPE_HTTP) at Cache.cc:3160:24
       frame #18: 0x0000000100095200 traffic_server`HttpCacheSM::open_write(this=0x0000001ded10c018, key=0x000000000b7df210, url=0x0000001ded10a380, request=0x0000001ded10a9f8, old_info=0x0000000000000000, pin_in_cache=0, retry=true, allow_multiple=false) at HttpCacheSM.cc:363:20
       frame #19: 0x0000000100104747 traffic_server`HttpSM::do_cache_prepare_action(this=0x0000001ded10a240, c_sm=0x0000001ded10c018, object_read_info=0x0000000000000000, retry=true, allow_multiple=false) at HttpSM.cc:4705:11
       frame #20: 0x000000010010aa38 traffic_server`HttpSM::do_cache_prepare_write(this=0x0000001ded10a240) at HttpSM.cc:4634:3
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org