You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/31 21:11:59 UTC

[GitHub] [tvm] mkatanbaf commented on a diff in pull request #12495: [microTVM] add the option to open a saved micro project for debugging

mkatanbaf commented on code in PR #12495:
URL: https://github.com/apache/tvm/pull/12495#discussion_r960030128


##########
python/tvm/micro/session.py:
##########
@@ -259,6 +259,8 @@ def compile_and_create_micro_session(
     mod_src_bytes: bytes,
     template_project_dir: str,
     project_options: dict = None,
+    build_dir: str = None,
+    debug: bool = False,

Review Comment:
   how about `skip_project_generation: bool = False`? yes, we can drive it from `build_dir` but I think that might cause some confusion and it's better to explicitly express it when we would like to skip project generation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org