You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Manfred Geiler (JIRA)" <ji...@codehaus.org> on 2006/04/11 13:52:48 UTC

[jira] Created: (MIDEA-49) WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes

WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes
----------------------------------------------------------------------------------------------

         Key: MIDEA-49
         URL: http://jira.codehaus.org/browse/MIDEA-49
     Project: Maven 2.x Idea Plugin
        Type: Bug

    Versions: 2.0    
    Reporter: Manfred Geiler


Currently reactor project modules are added with method "5":
            if ( linkModules && isReactorProject( artifact.getGroupId(), artifact.getArtifactId() ) )
            {
                containerElement.addAttribute( "type", "module" );
                containerElement.addAttribute( "name", artifact.getArtifactId() );
                Element methodAttribute = createElement( containerElement, "attribute" );
                methodAttribute.addAttribute( "name", "method" );
                methodAttribute.addAttribute( "value", "5" );   <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
                Element uriAttribute = createElement( containerElement, "attribute" );
                uriAttribute.addAttribute( "name", "URI" );
                uriAttribute.addAttribute( "value", "/WEB-INF/classes" );
            }
Well, method "5" seems to be "JAR module output and copy file to" in IDEA. This method is not compatible with the given URI attribute, which should rather be something like "/WEB-INF/lib/foobar.jar".
So, one way to fix this is to use method "1" ("Copy module output to") instead, then the used URI is correct. -->See patch 1.
Another (more maven-style way) is to fix the URI to be "/WEB-INF/lib/" + artifact.getArtifactId() + "-" + artifact.getVersion() + ".jar". -->See patch 2.

Regards,
Manfred


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MIDEA-49) WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes

Posted by "Manfred Geiler (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MIDEA-49?page=all ]

Manfred Geiler updated MIDEA-49:
--------------------------------

    Attachment: MIDEA-49-1.patch

> WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes
> ----------------------------------------------------------------------------------------------
>
>          Key: MIDEA-49
>          URL: http://jira.codehaus.org/browse/MIDEA-49
>      Project: Maven 2.x Idea Plugin
>         Type: Bug

>     Versions: 2.0
>     Reporter: Manfred Geiler
>  Attachments: MIDEA-49-1.patch, MIDEA-49-2.patch
>
>
> Currently reactor project modules are added with method "5":
>             if ( linkModules && isReactorProject( artifact.getGroupId(), artifact.getArtifactId() ) )
>             {
>                 containerElement.addAttribute( "type", "module" );
>                 containerElement.addAttribute( "name", artifact.getArtifactId() );
>                 Element methodAttribute = createElement( containerElement, "attribute" );
>                 methodAttribute.addAttribute( "name", "method" );
>                 methodAttribute.addAttribute( "value", "5" );   <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>                 Element uriAttribute = createElement( containerElement, "attribute" );
>                 uriAttribute.addAttribute( "name", "URI" );
>                 uriAttribute.addAttribute( "value", "/WEB-INF/classes" );
>             }
> Well, method "5" seems to be "JAR module output and copy file to" in IDEA. This method is not compatible with the given URI attribute, which should rather be something like "/WEB-INF/lib/foobar.jar".
> So, one way to fix this is to use method "1" ("Copy module output to") instead, then the used URI is correct. -->See patch 1.
> Another (more maven-style way) is to fix the URI to be "/WEB-INF/lib/" + artifact.getArtifactId() + "-" + artifact.getVersion() + ".jar". -->See patch 2.
> Regards,
> Manfred

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MIDEA-49) WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MIDEA-49?page=all ]

Brett Porter updated MIDEA-49:
------------------------------

    Fix Version: 2.0

> WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes
> ----------------------------------------------------------------------------------------------
>
>          Key: MIDEA-49
>          URL: http://jira.codehaus.org/browse/MIDEA-49
>      Project: Maven 2.x Idea Plugin
>         Type: Bug

>     Versions: 2.0
>     Reporter: Manfred Geiler
>      Fix For: 2.0
>  Attachments: MIDEA-49-1.patch, MIDEA-49-2.patch
>
>
> Currently reactor project modules are added with method "5":
>             if ( linkModules && isReactorProject( artifact.getGroupId(), artifact.getArtifactId() ) )
>             {
>                 containerElement.addAttribute( "type", "module" );
>                 containerElement.addAttribute( "name", artifact.getArtifactId() );
>                 Element methodAttribute = createElement( containerElement, "attribute" );
>                 methodAttribute.addAttribute( "name", "method" );
>                 methodAttribute.addAttribute( "value", "5" );   <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>                 Element uriAttribute = createElement( containerElement, "attribute" );
>                 uriAttribute.addAttribute( "name", "URI" );
>                 uriAttribute.addAttribute( "value", "/WEB-INF/classes" );
>             }
> Well, method "5" seems to be "JAR module output and copy file to" in IDEA. This method is not compatible with the given URI attribute, which should rather be something like "/WEB-INF/lib/foobar.jar".
> So, one way to fix this is to use method "1" ("Copy module output to") instead, then the used URI is correct. -->See patch 1.
> Another (more maven-style way) is to fix the URI to be "/WEB-INF/lib/" + artifact.getArtifactId() + "-" + artifact.getVersion() + ".jar". -->See patch 2.
> Regards,
> Manfred

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MIDEA-49) WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes

Posted by "Manfred Geiler (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MIDEA-49?page=all ]

Manfred Geiler updated MIDEA-49:
--------------------------------

    Attachment: MIDEA-49-2.patch

> WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes
> ----------------------------------------------------------------------------------------------
>
>          Key: MIDEA-49
>          URL: http://jira.codehaus.org/browse/MIDEA-49
>      Project: Maven 2.x Idea Plugin
>         Type: Bug

>     Versions: 2.0
>     Reporter: Manfred Geiler
>  Attachments: MIDEA-49-1.patch, MIDEA-49-2.patch
>
>
> Currently reactor project modules are added with method "5":
>             if ( linkModules && isReactorProject( artifact.getGroupId(), artifact.getArtifactId() ) )
>             {
>                 containerElement.addAttribute( "type", "module" );
>                 containerElement.addAttribute( "name", artifact.getArtifactId() );
>                 Element methodAttribute = createElement( containerElement, "attribute" );
>                 methodAttribute.addAttribute( "name", "method" );
>                 methodAttribute.addAttribute( "value", "5" );   <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>                 Element uriAttribute = createElement( containerElement, "attribute" );
>                 uriAttribute.addAttribute( "name", "URI" );
>                 uriAttribute.addAttribute( "value", "/WEB-INF/classes" );
>             }
> Well, method "5" seems to be "JAR module output and copy file to" in IDEA. This method is not compatible with the given URI attribute, which should rather be something like "/WEB-INF/lib/foobar.jar".
> So, one way to fix this is to use method "1" ("Copy module output to") instead, then the used URI is correct. -->See patch 1.
> Another (more maven-style way) is to fix the URI to be "/WEB-INF/lib/" + artifact.getArtifactId() + "-" + artifact.getVersion() + ".jar". -->See patch 2.
> Regards,
> Manfred

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (MIDEA-49) WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MIDEA-49?page=all ]
     
Brett Porter closed MIDEA-49:
-----------------------------

     Assign To: Brett Porter
    Resolution: Fixed

committed, thanks!

> WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes
> ----------------------------------------------------------------------------------------------
>
>          Key: MIDEA-49
>          URL: http://jira.codehaus.org/browse/MIDEA-49
>      Project: Maven 2.x Idea Plugin
>         Type: Bug

>     Versions: 2.0
>     Reporter: Manfred Geiler
>     Assignee: Brett Porter
>      Fix For: 2.0
>  Attachments: MIDEA-49-1.patch, MIDEA-49-2.patch
>
>
> Currently reactor project modules are added with method "5":
>             if ( linkModules && isReactorProject( artifact.getGroupId(), artifact.getArtifactId() ) )
>             {
>                 containerElement.addAttribute( "type", "module" );
>                 containerElement.addAttribute( "name", artifact.getArtifactId() );
>                 Element methodAttribute = createElement( containerElement, "attribute" );
>                 methodAttribute.addAttribute( "name", "method" );
>                 methodAttribute.addAttribute( "value", "5" );   <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>                 Element uriAttribute = createElement( containerElement, "attribute" );
>                 uriAttribute.addAttribute( "name", "URI" );
>                 uriAttribute.addAttribute( "value", "/WEB-INF/classes" );
>             }
> Well, method "5" seems to be "JAR module output and copy file to" in IDEA. This method is not compatible with the given URI attribute, which should rather be something like "/WEB-INF/lib/foobar.jar".
> So, one way to fix this is to use method "1" ("Copy module output to") instead, then the used URI is correct. -->See patch 1.
> Another (more maven-style way) is to fix the URI to be "/WEB-INF/lib/" + artifact.getArtifactId() + "-" + artifact.getVersion() + ".jar". -->See patch 2.
> Regards,
> Manfred

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira