[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11467: sql between function should be inclusive

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on code in PR #11467:
URL: https://github.com/apache/pinot/pull/11467#discussion_r1311178944


##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ComparisonFunctions.java:
##########
@@ -61,6 +61,6 @@ public static boolean equals(double a, double b) {
 
   @ScalarFunction
   public static boolean between(double val, double a, double b) {
-    return val > a && val < b;
+    return val >= a && val <= b;

Review Comment:
   I think it's not used in normal filter workflow, but in intermediate stage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org