[jira] [Commented] (YARN-4828) Create a pull request template for github

["Sangjin Lee (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612930#comment-15612930 ] 

Sangjin Lee commented on YARN-4828:
-----------------------------------

Thanks for the patch [~GergelyNovak]! This is almost there.

A couple of nits:
- I believe we need the license header even on this file, no?
- There are some missing spaces below before and after the brackets:
{noformat}
please read the[How to contribute guide](https://wiki.apache.org/hadoop/HowToContribute)first
{noformat}

[~steve_l], feedback on the patch?

> Create a pull request template for github
> -----------------------------------------
>
>                 Key: YARN-4828
>                 URL: https://issues.apache.org/jira/browse/YARN-4828
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0-alpha1
>         Environment: github
>            Reporter: Steve Loughran
>            Assignee: Gergely Novák
>            Priority: Minor
>              Labels: oct16-easy
>         Attachments: YARN-4828.001.patch
>
>
> We're starting to see PRs appear without any JIRA, explanation etc. These are going to be ignored without them.
> It's possible to [create a PR text template](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/) under {{.github/PULL_REQUEST_TEMPLATE}}
> We can do such a template, which provides template summary points, such as:
> * which JIRA
> * if against an object store, how did you test it?
> * if its a shell script, how did you test it?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org